From: Michael Schutte <michi@uiae.at> To: kbd@lists.altlinux.org Subject: [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics Date: Wed, 13 Oct 2010 17:07:26 +0200 Message-ID: <1286982446-15811-1-git-send-email-michi@uiae.at> (raw) struct ccc in compose_as_usua[() uses three char members of unspecified signedness; in case the compiler decides that they should be signed, negative integers will end up in the accent table for c3 > 127. Avoid the problem by explicitly using unsigned chars. Signed-off-by: Michael Schutte <michi@uiae.at> --- src/loadkeys.y | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/loadkeys.y b/src/loadkeys.y index c8bb7cc..cc7e2ab 100644 --- a/src/loadkeys.y +++ b/src/loadkeys.y @@ -1181,7 +1181,7 @@ compose_as_usual(char *charset) { exit(1); } else { struct ccc { - char c1, c2, c3; + unsigned char c1, c2, c3; } def_latin1_composes[68] = { { '`', 'A', 0300 }, { '`', 'a', 0340 }, { '\'', 'A', 0301 }, { '\'', 'a', 0341 }, -- 1.7.1
next reply other threads:[~2010-10-13 15:07 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-13 15:07 Michael Schutte [this message] 2010-10-16 20:21 ` Alexey Gladkov 2010-10-18 7:13 ` Alexey Gladkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1286982446-15811-1-git-send-email-michi@uiae.at \ --to=michi@uiae.at \ --cc=kbd@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux console tools development discussion This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \ kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com public-inbox-index kbd Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.kbd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git