From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653065606; x=1684601606; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XPWjWGO2u02YTK9gOYDVxcD0MaXucU3uX0i4aRIuWQg=; b=fWglojthBVVRyNaUMg15/+eQTqucgNOuTtMxYN3HIloiZwVWCWkL7v2A 6hT0VKX0ekqSfOfG6VQt2LMZNePaxPUFMFM6i655hYAWo/gQXMMTajzUe INzoSq4IXf0kd1sgescPOgtO2xxSM0Zz+poILfABDIfgvvHBSUBhDY9qX uWN/f7PMiby6uDw5oASrUmaYU9La6exuFlIdeFFHIWpTI5NCx79IqP4J3 EkfQJuexTQQJCYcmKZTPXm/MmBkgzcxwTwnr9Em5oz4JbWYN28lNIydbc rp7KuP8/BsO0qO9p5QVie1wzSFVE1KPIpXucHiKDZUHzxhFtufBY0/Dw2 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="252547189" X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="252547189" X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="570898404" Date: Fri, 20 May 2022 19:53:15 +0300 From: Andy Shevchenko To: asheplyakov@yandex.ru Message-ID: References: <20220520162849.1554351-1-asheplyakov@yandex.ru> <20220520162849.1554351-19-asheplyakov@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520162849.1554351-19-asheplyakov@yandex.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Fri, 20 May 2022 21:36:18 +0300 Cc: Alexey Sheplyakov , "Vadim V . Vlasov" , Evgeny Sinelnikov , Vitaly Chikunov , Igor Chudov , Greg Kroah-Hartman , Serge Semin , devel@lists.altlinux.org Subject: Re: [devel] [PATCH 18/35] [rejected] serial: 8250_dw: verify clock rate in dw8250_set_termios X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 16:53:28 -0000 Archived-At: List-Archive: List-Post: On Fri, May 20, 2022 at 08:28:32PM +0400, asheplyakov@yandex.ru wrote: > From: Alexey Sheplyakov > > Refuse to change the clock rate if clk_round_rate() returns > a rate which is way too off (i.e. by more than 1/16 from the one > necessary for a given baud rate). In particular this happens if > the requested rate is below the minimum supported by the clock. > > Fixes the UART console on Baikal-M SoC. Without this patch the > console gets garbled immediately after loading the driver. > dw8250_set_termios tries to configure the baud rate (115200), > and calls clk_round_rate to figure out the supported rate closest > to 1843200 Hz (which is 115200 * 16). However the (SoC-specific) > clock driver returns 4705882 Hz. This frequency is way too off, > hence after setting it the console gets garbled. > > Signed-off-by: Alexey Sheplyakov > Signed-off-by: Vadim V. Vlasov > > Cc: Andy Shevchenko > Cc: Greg Kroah-Hartman > Cc: Serge Semin > X-feature-Baikal-M I don't know if you have any specific hooks, but the blank lines are not acceptable in the tag block. I think you have script which cuts the last block from the real (public) patch. In any case, the main point here is to point out that externals probably won't be happy seeing this internal stuff. -- With Best Regards, Andy Shevchenko