From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=nWzxKtpuhQctqIZ8O/tUdGWuJFYGbStoRDzr1iLGnww=; b=R6Enh429v33fXcOhWJDFPu5yyCLZVNtSt4l53dC72OLgndxMBQAi8JWNP4sZZ9hc7N c0OwXkDo9E+1ifOAMZdIykmWRSuKQ/ESQKJnX/wxA0mUih1u6ec910RdvMUcw/cTHQ0k /rf+qaUN6oMWiISpcEyTckHCOpkNZ86PD5VrWQS4vSFPGqRiYyagsRRQDUQHBlnmcR07 ObSed7Gw+VaXpO+D4/ipdFQUFVD6ZM8foOd9m6wkCshy2YPG6717Dcy33+o6ZeIaXM63 ioZkKVuGO4KHfU0avHqWHva26qoqRHEkhbUv6Jx4F6LwJVivuhkr3BMxzZWRtHelESGO Eurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=nWzxKtpuhQctqIZ8O/tUdGWuJFYGbStoRDzr1iLGnww=; b=bfeW8QZRmC6bYL81+Kx+fg+kKcAMqlJaKVtI1olYtkRujWqig1s1prF8pvWQOjspBt 3XqRGb3AJlRgFglhO2Dj/vLsrgMzI01kDyAkLpQRH+cKdlvxUuy5vdPOqaBK/8wkpbOV C5+vAuUjVcXnOGUadPRG24jENOoJV7BEpMfDiKyitgKgX3co8GXcazzK+e0p+EhIo5dx KGBp6ZFRH7pYKjGeC3RO2k48qavChqs9p3tUhNueLoCvhwWKFKY27xjaLV93jynCme0X AByfNCMP50MGsb48Hn4GWb0C0Cx0TW3OTzh/QB3bIyNxSj9IFLPm1STYX4aCEaPcSo6N drYw== X-Gm-Message-State: AOAM531SSKZk6lf+lwQIGQatwbPakEiWAwfNMt+GMw3HB9B8WccvGPRm OMUE4AaFGEYztH2sCrIf/RSh3X6urE52My7FikbnXHtA X-Google-Smtp-Source: ABdhPJwLpgnrQsSWBfQ9lRP2LF5rDpoRxip//CM/9QuNiL1NDQ1QNWWNgdX4U5IDSxdYY8u7AYWcpA5Jf2mi8/gwxU8= X-Received: by 2002:a5e:c90c:: with SMTP id z12mr8559167iol.127.1591364463670; Fri, 05 Jun 2020 06:41:03 -0700 (PDT) MIME-Version: 1.0 References: <20200604195811.3881130-1-vseleznv@altlinux.org> <20200604195811.3881130-2-vseleznv@altlinux.org> In-Reply-To: <20200604195811.3881130-2-vseleznv@altlinux.org> From: Alexey Tourbin Date: Fri, 5 Jun 2020 16:40:52 +0300 Message-ID: To: ALT Linux Team development discussions Content-Type: text/plain; charset="UTF-8" Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2020 13:41:07 -0000 Archived-At: List-Archive: List-Post: On Thu, Jun 4, 2020 at 10:58 PM Vladimir D. Seleznev wrote: > Introduce task post-build processing. It finds subtasks with package > rebuild and if the rebuilt packages identical to the same packages in > the target repo it optimizes them. It doesn't make much sense. When we rebuild a package without changing the release, we expect something else in the package to change because of the rebuild (e.g. a binary will be linked with a new library version). If the package hasn't changed, it is an alarming condition which indicates that some of the packager's assumptions were wrong (e.g. the binary actually doesn't link with the library). So should we really "optimize" this case? We might as well prohibit it! The packager should be cognizant that some of his efforts aren't making any difference. :)