From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexey.tourbin@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no
 version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=dP9+yCskJFNjM6xr3iDLnr/5nmkc06+cnt37u+ujMyc=;
 b=GkdhtrINxBpCYfP3IlHcGxsO8ymyylFf+iwiYEEVPwtNq+PW2wdiO3HcLggDFn6kUl
 NIqXVUgCkfK9x27jEeCONCnT2O+r1U2CkZkfnf6gxPQtlcEWv+CIwQEsEdCATngq1zzI
 l6+0WQnN3+U7PiNc8JEv3lPvqWu9XMwdpUlp1w0p7LqDL06L0mKYm8MRqWTaM4RfBZlf
 wELKk7cf0Wy4p+TcYqXdd8zK9tha2RtBGGYXsWl+QuIiw3OgnwnamCuAzdUaLDbaH834
 E/bMMw8FnWl7W5oCQ7xNCwOUOi9jy6c0H2LYlkDXG8trgv6K0x4S9pruJYKdfdZmNyb+
 RvoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=dP9+yCskJFNjM6xr3iDLnr/5nmkc06+cnt37u+ujMyc=;
 b=AhQSOvj/o3V6ICIYN6F85ptYL8YhcnlcARgkTL2TZdaoJpHfz6IGuwMxQxfZ1dCVgl
 WdDihumw2CfS61Toj0AuPMbpLaIIlE7N4uXKhge1UtNwob5R6jp37PwaHCYYaT6fQ7ev
 ecVuCBOZkxm+iQLF+21gLtpRTTruLUbytcanbTOZwNNqkaedeiQicMkG3iyz8ScfF3C5
 LR8WXjaopD0P0y4vSt+nOkFwq/GebJEvv529AEt+m/dJEKjE59/awmsc0uYIWv5cOWoQ
 jHOsDGs0ISpCXSLEJaFculzOb0j436pBkmtOd5yzFw53G8EbOzwwZgt2yVEaYw1rgzuI
 L3bw==
X-Gm-Message-State: APjAAAUJ4B5t3OcRdwNR4ggETxuOd98ysLVu/2Qd/IOx81WCsvBDvkFS
 4HaacWU39SSuG3ZYw3IB8WmwfQ2R+jcKyewuZi4tbA==
X-Google-Smtp-Source: APXvYqxM83P8pAozB/RhgWsxL4vp4ds4ejuECbER+xPZpDKmP2kmR3XRODkqfRbXB1FlpSrT6Ye9NmC7j9Kxfhu+XBM=
X-Received: by 2002:a5d:9701:: with SMTP id h1mr23885782iol.12.1576002108519; 
 Tue, 10 Dec 2019 10:21:48 -0800 (PST)
MIME-Version: 1.0
References: <20191210152343.33867-1-darktemplar@altlinux.org>
 <20191210152343.33867-2-darktemplar@altlinux.org>
In-Reply-To: <20191210152343.33867-2-darktemplar@altlinux.org>
From: Alexey Tourbin <alexey.tourbin@gmail.com>
Date: Tue, 10 Dec 2019 21:21:37 +0300
Message-ID: <CA+qzenkiJHdn4PvXi04PHxMpL0adP8FBYtQ=J_Eefndrgn56zA@mail.gmail.com>
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [devel] [PATCH for apt 01/38] Replace post-increments with
	pre-increments
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2019 18:21:52 -0000
Archived-At: <http://lore.altlinux.org/devel/CA+qzenkiJHdn4PvXi04PHxMpL0adP8FBYtQ=J_Eefndrgn56zA@mail.gmail.com/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Tue, Dec 10, 2019 at 6:25 PM Aleksei Nikiforov
<darktemplar@altlinux.org> wrote:
> +++ b/apt/apt-pkg/acquire-item.cc
> @@ -486,7 +486,7 @@ void pkgAcqIndexRel::Done(const string &Message,unsigned long long Size,const st
>
>          bool found = false;
>          for (vector<string>::const_iterator I = Repository->FingerPrint.begin();
> -             I != Repository->FingerPrint.end(); I++)
> +             I != Repository->FingerPrint.end(); ++I)
>          {
>             // Match fingerprint of Release file
>             if ((*I) == FingerPrint)

How does that fix anything? It doesn't! Avoid unnecessary changes,
only make those beaming with thought.  As Pouchkine wrote, "strashisya
uchasti bessmyslennykh pevtsov".