From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=yfh/ERBMJQj3X6BdF0kHQv2bNXcRcQ/MSjC6Ew448Nc=; b=TEteuNAu6gAryaWKZGvCSMaWY19Cz++CRvvChyB95IM3tKr9fKeI93+XFy85wKo04J 29vz4JO9kbiSgPJKakXSHorXVowKXntMitRg3DZ0facWoIHx0jKWaE8EnzYZZgWxIBwO ubTwZjnlSClvAVIKFe3B1HrM+16+XS+NsGgI2LPBNY9akItwFr2SQVgKsS90h43XTM0N J6SyLeM43ivn+wquMVhTzkqO6NAhuyMp+ET4PC2CUSBmFEEWXgMOdbvX9hXhjnK8iGeq TsYbPGWJeYbEGGQJ6Qup8Wbr9JP+XTqMQWaZwwDBBQ89bW7HTfTJm3J+aoU1SEIDR+lI 4Xfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=yfh/ERBMJQj3X6BdF0kHQv2bNXcRcQ/MSjC6Ew448Nc=; b=OR/JmAB2WQ4WXTMIHrtZjGnqossL7q7oO+JkL2yEF5rciTEd9HgzIbY9mgt2B2zSBj YaMX4X3Pfr1tPpz1d01unNovLImI4kXswZd4aJrH+FYfbX1QO+w+881lmUJp+Zz1POXd NdqYeeOwRGdpSsLXdJPFYuTG8MzNOc/GGlWDp6Z9NUXMHmCag+H4KhD8k2LTIiz+0beT 48OBqMoiCwKzQ3ZD7iqQcYkhiYytV8f3lDgiqEV2WyBTjMUk9XQmmtqW74YNpEchY5VQ QpL4D9G5B53o0y1NKIZGRn+RvP3oonhGuAw/rHfAM9nJ2M0Yqo5nuRvA3XUCDiYP6hjB skdQ== X-Gm-Message-State: AOAM531JNbjkhNjEWOa06GLMl6KXjvQqPeNe0OqdcdN3YZfjx9eu99Zo LczjpuoV+qV0jNmIFAV8k5d6uSdQaYqnJRHxDo8p2nN+ X-Google-Smtp-Source: ABdhPJz4NRRVWMY8bgevgm9dBj1ZXio8Q5tdKGqIoBLGxtGdNI5/eIOJ+IVKONNEhgFpjzrHLCDWixyMT6VH1V9PQIk= X-Received: by 2002:a05:6e02:eb0:: with SMTP id u16mr13839241ilj.81.1591450952642; Sat, 06 Jun 2020 06:42:32 -0700 (PDT) MIME-Version: 1.0 References: <20200604195811.3881130-1-vseleznv@altlinux.org> <20200604195811.3881130-2-vseleznv@altlinux.org> <20200605142254.GA4019241@portlab> In-Reply-To: <20200605142254.GA4019241@portlab> From: Alexey Tourbin Date: Sat, 6 Jun 2020 16:42:21 +0300 Message-ID: To: ALT Linux Team development discussions Content-Type: text/plain; charset="UTF-8" Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jun 2020 13:42:36 -0000 Archived-At: List-Archive: List-Post: On Fri, Jun 5, 2020 at 5:23 PM Vladimir D. Seleznev wrote: > > > Introduce task post-build processing. It finds subtasks with package > > > rebuild and if the rebuilt packages identical to the same packages in > > > the target repo it optimizes them. > > > > It doesn't make much sense. When we rebuild a package without changing > > the release, we expect something else in the package to change because > > of the rebuild (e.g. a binary will be linked with a new library > > version). If the package hasn't changed, it is an alarming condition > > which indicates that some of the packager's assumptions were wrong > > (e.g. the binary actually doesn't link with the library). So should we > > really "optimize" this case? We might as well prohibit it! > > By "prohibit" you mean make task build fail? I would say that it is > unnecessary. It'd produce additional difficulties for maintainers > without any profit. The difficulties are all in the maintainers' heads. There must be a valid reason for rebuilding a package. > > The packager should be cognizant that some of his efforts aren't > > making any difference. :) > > But packager can know that this kind of effort aren't making any > difference because of build log warning. And this can be convenient in > case of mass rebuild, for example. So are we to permit the tasks that don't change the repo? Then you should also optimize base/pkglist and the and release files, their timestamps should not be clobbered. So that the end user immediately sees there's no need to update from the repo, although a few tasks have been committed. Nice optimization this, eh?