From: "Slava Semushin" <slava.semushin@gmail.com> To: "ALT Devel discussion list" <devel@lists.altlinux.org> Subject: Re: [devel] [git update] packages/apt: heads/master Date: Tue, 18 Dec 2007 14:34:58 +0600 Message-ID: <75e139a00712180034q7e92798blf091948e0473c620@mail.gmail.com> (raw) In-Reply-To: <20071217194406.A22628E8032@ssh.git.local.altlinux.org> 2007/12/18, Dmitry V. Levin <ldv / altlinux.org>: > Update of /people/ldv/packages/apt.git [...] > +--- a/apt/apt-pkg/algorithms.cc > ++++ b/apt/apt-pkg/algorithms.cc [...] > ++/* Like strcmp, but compares digit sections by number value. > ++ * E.g.: tar-1.10 > tar-1.9 > tar-1.1a > ++ * (while strcmp gives tar-1.10 < tar-1.9). */ > ++static int nameCompare(const char* n1, const char* n2) > ++{ > ++ while(*n1 && *n2) { > ++ if(isdigit(*n1) && isdigit(*n2)) { > ++ unsigned long long i1, i2; > ++ i1 = strtoull(n1, const_cast<char **>(&n1), 10); > ++ i2 = strtoull(n2, const_cast<char **>(&n2), 10); > ++ if(i1 != i2) > ++ return (i1 > i2) ? 1 : -1; > ++ } else if(*n1 != *n2) { > ++ return (*n1 > *n2) ? 1 : -1; > ++ } else { > ++ n1++; > ++ n2++; > ++ } > ++ } > ++ return 0; > ++} [...] Почему бы не использовать strverscmp() для этих целей? Оно, правда, GNU extenstion, но портабельность, как понимаю, для нас не критична. Зато она более стандартна, чем самописный nameCompare() и лучше документирована. -- + Slava Semushin | slava.semushin @ gmail.com + ALT Linux Team | php-coder @ altlinux.ru
next parent reply other threads:[~2007-12-18 8:34 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-12-18 8:34 ` Slava Semushin [this message] 2007-12-18 9:42 ` Alex Myltsev 2007-12-18 10:18 ` Dmitry V. Levin 2007-12-18 10:35 ` Alexey Rusakov 2007-12-18 10:38 ` Dmitry V. Levin 2007-12-18 11:00 ` Alexey Rusakov 2007-12-18 14:04 ` Dmitry V. Levin 2007-12-19 6:17 ` Slava Semushin 2008-03-30 4:28 ` [devel] apt-pkg/algorithms.cc nameCompare Alexey Tourbin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=75e139a00712180034q7e92798blf091948e0473c620@mail.gmail.com \ --to=slava.semushin@gmail.com \ --cc=devel@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Team development discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \ devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru public-inbox-index devel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git