* Re: [devel] [git update] packages/katrin: heads/master
@ 2007-06-25 9:28 ` Slava Semushin
2007-06-25 10:08 ` Denis Klimov
0 siblings, 1 reply; 3+ messages in thread
From: Slava Semushin @ 2007-06-25 9:28 UTC (permalink / raw)
To: ALT Devel discussion list
2007/6/25, Denis Klimov <zver / altlinux.org>:
[...]
> - char *iface = strdup("eth0");
> - char *allrate = strdup("100mbit");
> + char iface[10] = "eth0";
> + char allrate[10] = "100mbit";
Ммм... если вы решили сделать так, то не надо тогда free() вызывать в конце.
[...]
> - char prog[] = "/tmp/katrin-tc-tmp";
> - char path[] = "/tmp";
> + char prog[25] = "";
> + strlcpy(prog, "/tmp/katrin-tc.XXXXXX", sizeof prog);
> + mktemp(prog);
> FILE *fh = fopen(prog,"w");
> +
:-)
BUGS
Never use mktemp(). Some implementations follow 4.3BSD and replace
XXXXXX by the current process ID and a single letter, so that at most
26 different names can be returned. Since on the one hand the names
are easy to guess, and on the other hand there is a race between test-
ing whether the name exists and opening the file, every use of mktemp()
is a security risk. The race is avoided by mkstemp(3).
P.S. Я, наверное, всем уже надоел :))
--
+ Slava Semushin | slava.semushin @ gmail.com
+ ALT Linux Team | php-coder @ altlinux.ru
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [devel] [git update] packages/katrin: heads/master
2007-06-25 9:28 ` [devel] [git update] packages/katrin: heads/master Slava Semushin
@ 2007-06-25 10:08 ` Denis Klimov
2007-06-25 10:20 ` Slava Semushin
0 siblings, 1 reply; 3+ messages in thread
From: Denis Klimov @ 2007-06-25 10:08 UTC (permalink / raw)
To: ALT Devel discussion list
On Mon, 25 Jun 2007 16:28:48 +0700 Slava Semushin wrote:
>
> [...]
> > - char prog[] = "/tmp/katrin-tc-tmp";
> > - char path[] = "/tmp";
> > + char prog[25] = "";
> > + strlcpy(prog, "/tmp/katrin-tc.XXXXXX", sizeof prog);
> > + mktemp(prog);
> > FILE *fh = fopen(prog,"w");
> > +
>
> :-)
>
> BUGS
> Never use mktemp(). Some implementations follow 4.3BSD and replace
> XXXXXX by the current process ID and a single letter, so that at most
> 26 different names can be returned. Since on the one hand the names
> are easy to guess, and on the other hand there is a race between test-
> ing whether the name exists and opening the file, every use of mktemp()
> is a security risk. The race is avoided by mkstemp(3).
>
> P.S. Я, наверное, всем уже надоел :))
>
>
> --
> + Slava Semushin | slava.semushin @ gmail.com
> + ALT Linux Team | php-coder @ altlinux.ru
хм, mkstemp возвращает дескриптор открытого им файла, у меня же задача - записать во временый файл сгенерированный скрипт, чтобы потом его запустить, но после записи как я узнаю имя этого скрипта-файла, который необходимо запустить?
--
Denis Klimov
zver
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [devel] [git update] packages/katrin: heads/master
2007-06-25 10:08 ` Denis Klimov
@ 2007-06-25 10:20 ` Slava Semushin
0 siblings, 0 replies; 3+ messages in thread
From: Slava Semushin @ 2007-06-25 10:20 UTC (permalink / raw)
To: ALT Devel discussion list
2007/6/25, Denis Klimov <kliden / km.ru>:
[...]
> [...] но после записи как я узнаю имя этого скрипта-файла, который необходимо запустить?
Since it will be modified, template must not be a string
constant, but should be
declared as a character array.
Насколько понимаю, она также изменяет имя файла в переданном ей
массиве символов.
--
+ Slava Semushin | slava.semushin @ gmail.com
+ ALT Linux Team | php-coder @ altlinux.ru
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-25 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-25 9:28 ` [devel] [git update] packages/katrin: heads/master Slava Semushin
2007-06-25 10:08 ` Denis Klimov
2007-06-25 10:20 ` Slava Semushin
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git