From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <root@mmedia2.kemsu.ru>
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on sa.int.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DNS_FROM_OPENWHOIS
	autolearn=no version=3.2.5
Message-ID: <4DCB489C.2000000@mmedia2.kemsu.ru>
Date: Thu, 12 May 2011 09:40:28 +0700
From: REAL <root@mmedia2.kemsu.ru>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.9.2.16pre) Gecko/20110308 Thunderbird/3.1.10pre
MIME-Version: 1.0
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: [devel] Fwd: ndiswrapper is broken since kernel 2.6.37
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2011 02:38:33 -0000
Archived-At: <http://lore.altlinux.org/devel/4DCB489C.2000000@mmedia2.kemsu.ru/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

Привет!

Честно говоря, не понял, а чём речь. Мой фикс был взят из открытых 
источников, если чего-то там не хватает, жду патчей.

-------- Исходное сообщение --------
Тема: ndiswrapper is broken since kernel 2.6.37
Дата: Wed, 11 May 2011 19:15:40 +0400
От: (GalaxyMaster) <galaxy@openwall.com>
Кому: ldv@altlinux.org
Копия: Eugeny A. Rostovtsev <real@altlinux.org>

Dmitry,

I just wanted to notify you that the following commit to git.alt breaks
the ndiswrapper:
===
author	Eugeny A. Rostovtsev <real@altlinux.org>	
Mon, 28 Feb 2011 04:09:11 +0000 (04:09 +0000)
committer	Eugeny A. Rostovtsev <real@altlinux.org>	
Mon, 28 Feb 2011 04:09:11 +0000 (04:09 +0000)
commit	cc4ebec7b18be55447e4e8c8170ab7d52ed98cd0
http://git.altlinux.org/gears/k/kernel-modules-ndiswrapper-std-def.git?p=kernel-modules-ndiswrapper-std-def.git;a=commit;h=cc4ebec7b18be55447e4e8c8170ab7d52ed98cd0
===

It includes the following patch:
===
--- ndiswrapper-1.56/driver/loader.c.old	2011-02-28 04:07:27.000000000 
+0000
+++ ndiswrapper-1.56/driver/loader.c	2011-02-28 04:07:33.000000000 +0000
@@ -831,7 +831,7 @@

  static struct file_operations wrapper_fops = {
     .owner          = THIS_MODULE,
-	.ioctl		= wrapper_ioctl,
+	.unlocked_ioctl		= wrapper_ioctl,
     .release	= wrapper_ioctl_release,
  };
===

but replacing .ioctl with .unlocked_ioctl without updating 
wrapper_ioctl() is
plainly wrong since unlocked_ioctl() has different arguments (e.g. 
there is no
inode structure anymore).  I believe, removing the first argument from the
wrapper_ioctl() definition would be enough to fix the issue.

Could you please be so kind and forward this message to the maintainer (I
failed to locate one).  I'm also CC'ing Eugeny.



-- 
(GM)