From: REAL <root@mmedia2.kemsu.ru> To: ALT Linux Team development discussions <devel@lists.altlinux.org> Subject: [devel] Fwd: ndiswrapper is broken since kernel 2.6.37 Date: Thu, 12 May 2011 09:40:28 +0700 Message-ID: <4DCB489C.2000000@mmedia2.kemsu.ru> (raw) Привет! Честно говоря, не понял, а чём речь. Мой фикс был взят из открытых источников, если чего-то там не хватает, жду патчей. -------- Исходное сообщение -------- Тема: ndiswrapper is broken since kernel 2.6.37 Дата: Wed, 11 May 2011 19:15:40 +0400 От: (GalaxyMaster) <galaxy@openwall.com> Кому: ldv@altlinux.org Копия: Eugeny A. Rostovtsev <real@altlinux.org> Dmitry, I just wanted to notify you that the following commit to git.alt breaks the ndiswrapper: === author Eugeny A. Rostovtsev <real@altlinux.org> Mon, 28 Feb 2011 04:09:11 +0000 (04:09 +0000) committer Eugeny A. Rostovtsev <real@altlinux.org> Mon, 28 Feb 2011 04:09:11 +0000 (04:09 +0000) commit cc4ebec7b18be55447e4e8c8170ab7d52ed98cd0 http://git.altlinux.org/gears/k/kernel-modules-ndiswrapper-std-def.git?p=kernel-modules-ndiswrapper-std-def.git;a=commit;h=cc4ebec7b18be55447e4e8c8170ab7d52ed98cd0 === It includes the following patch: === --- ndiswrapper-1.56/driver/loader.c.old 2011-02-28 04:07:27.000000000 +0000 +++ ndiswrapper-1.56/driver/loader.c 2011-02-28 04:07:33.000000000 +0000 @@ -831,7 +831,7 @@ static struct file_operations wrapper_fops = { .owner = THIS_MODULE, - .ioctl = wrapper_ioctl, + .unlocked_ioctl = wrapper_ioctl, .release = wrapper_ioctl_release, }; === but replacing .ioctl with .unlocked_ioctl without updating wrapper_ioctl() is plainly wrong since unlocked_ioctl() has different arguments (e.g. there is no inode structure anymore). I believe, removing the first argument from the wrapper_ioctl() definition would be enough to fix the issue. Could you please be so kind and forward this message to the maintainer (I failed to locate one). I'm also CC'ing Eugeny. -- (GM)
next reply other threads:[~2011-05-12 2:40 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-12 2:40 REAL [this message] 2011-05-12 4:28 ` Damir Shayhutdinov 2011-05-12 5:16 ` REAL 2011-05-12 5:58 ` Michael Shigorin 2011-05-12 6:07 ` REAL 2011-05-12 6:25 ` REAL
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4DCB489C.2000000@mmedia2.kemsu.ru \ --to=root@mmedia2.kemsu.ru \ --cc=devel@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Team development discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \ devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru public-inbox-index devel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git