From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ab@altlinux.org>
Message-ID: <474D52E3.9030808@altlinux.org>
Date: Wed, 28 Nov 2007 14:37:07 +0300
From: Alexander Bokovoy <ab@altlinux.org>
User-Agent: Thunderbird 2.0.0.6 (X11/20071022)
MIME-Version: 1.0
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
References: <20071125120814.GA22522@basalt.office.altlinux.org>	<20071125195520.GS28492@osdn.org.ua>	<20071125211632.GC30421@basalt.office.altlinux.org>	<20071126085538.GB13915@mw.local.seiros.ru>	<474C3898.6090500@sandy.ru>	<20071127154518.GM11953@basalt.office.altlinux.org>	<75e139a00711272256i770bd25ci550debea6f99b693@mail.gmail.com>	<474D2CED.30401@sandy.ru>
	<474D3678.508@altlinux.org> <20071128095531.GM361@solemn.turbinal>
In-Reply-To: <20071128095531.GM361@solemn.turbinal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - glaucus.site5.com
X-AntiAbuse: Original Domain - lists.altlinux.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - altlinux.org
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Subject: Re: [devel] IA: destination buffer overflow - ppp
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2007 11:37:12 -0000
Archived-At: <http://lore.altlinux.org/devel/474D52E3.9030808@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

Alexey Tourbin пишет:
> On Wed, Nov 28, 2007 at 12:35:52PM +0300, Alexander Bokovoy wrote:
>> Еще бы оно работало. Вы же просто повторили ерунду за авторами этого
>> плагина. sizeof(ttyname), как и sizeof(name), равносильны sizeof(char *)
>> и равны размеру указателя, но никак не размеру строки. Там нужно
>> использовать strlen(ttyname).
> 
> UINT4 rc_map2id(char *name)
> {               
>         struct map2id_s *p;
>         char ttyname[PATH_MAX];
> 
>         *ttyname = '\0';
>         if (*name != '/')
>                 strcpy(ttyname, "/dev/");
>         
>         strncat(ttyname, name, sizeof(ttyname));
>                 
>         for(p = map2id_list; p; p = p->next)
>                 if (!strcmp(ttyname, p->name)) return p->id;
>                 
>         warn("rc_map2id: can't find tty %s in map database", ttyname);
>                 
>         return 0;                                                                                                           
> }                                                                                                                            
> 
> Есть любители кодить на язычке Си всякие прикладные вещи.
> И там это ещё называется "качество кода" или как-то так.
Это не качество кода, это несоответствие занимаемой должности. :-)

-- 
/ Alexander Bokovoy
Samba Team                      http://www.samba.org/
ALT Linux Team                  http://www.altlinux.org/
Midgard Project Ry              http://www.midgard-project.org/