From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ab@altlinux.org>
Message-ID: <474D3678.508@altlinux.org>
Date: Wed, 28 Nov 2007 12:35:52 +0300
From: Alexander Bokovoy <ab@altlinux.org>
User-Agent: Thunderbird 2.0.0.6 (X11/20071022)
MIME-Version: 1.0
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
References: <20071125120814.GA22522@basalt.office.altlinux.org>	<20071125195520.GS28492@osdn.org.ua>	<20071125211632.GC30421@basalt.office.altlinux.org>	<20071126085538.GB13915@mw.local.seiros.ru>	<474C3898.6090500@sandy.ru>	<20071127154518.GM11953@basalt.office.altlinux.org>	<75e139a00711272256i770bd25ci550debea6f99b693@mail.gmail.com>
	<474D2CED.30401@sandy.ru>
In-Reply-To: <474D2CED.30401@sandy.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - glaucus.site5.com
X-AntiAbuse: Original Domain - lists.altlinux.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - altlinux.org
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Subject: Re: [devel] IA: destination buffer overflow - ppp
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2007 09:35:56 -0000
Archived-At: <http://lore.altlinux.org/devel/474D3678.508@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

Dmitriy Khanzhin пишет:
> Slava Semushin пишет:
>> 2007/11/27, Dmitry V. Levin <ldv@altlinux.org>:
>>> On Tue, Nov 27, 2007 at 06:32:40PM +0300, Dmitriy Khanzhin wrote:
>>> 
>>>> -     strncat(ttyname, name, sizeof(ttyname));
>> + strncat(ttyname, name, sizeof(ttyname)-1);
>> 
>>> Автор этого кода не справился с функцией strncat. Исправление
>>> тривиально.
>> Фикс должен быть таким (см. выше)? Или нет?
>> 
> Вот так собралось без warning'а (аттач).
Еще бы оно работало. Вы же просто повторили ерунду за авторами этого
плагина. sizeof(ttyname), как и sizeof(name), равносильны sizeof(char *)
и равны размеру указателя, но никак не размеру строки. Там нужно
использовать strlen(ttyname).
-- 
/ Alexander Bokovoy
Samba Team                      http://www.samba.org/
ALT Linux Team                  http://www.altlinux.org/
Midgard Project Ry              http://www.midgard-project.org/