* Re: [devel] openvz arp
@ 2006-11-26 13:51 ` Dmitry V. Levin
2006-11-27 5:55 ` Dmitry Lebkov
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry V. Levin @ 2006-11-26 13:51 UTC (permalink / raw)
To: ALT Devel discussion list
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
On Thu, Sep 21, 2006 at 02:33:34PM +0400, Dmitry V. Levin wrote:
> On Thu, Sep 21, 2006 at 10:07:37AM +0400, Alexey I. Froloff wrote:
> > * Dmitry V. Levin <ldv@> [060920 20:37]:
> > > Можно, конечно, но на месте upstream'а я бы завёл список ip-адресов,
> > > которые не нужно проверять vzarpipdetect'ом, и список ip-адресов, которые
> > > не нужно анонсировать vzarpipset'ом и vzarp'ом.
> > А где держать этот список и в каком виде? Что-то типа
> > ARP_SKIP_DETECT/ARP_SKIP_ANNOUNCE со списком подсетей в
> > /etc/sysconfig/vz ?
>
> Да, я думаю предложить им такое.
Я передумал и теперь предполагаю сделать так:
vzarp: When adding ip, do not announce it on those ifaces where it is not local.
vzarpipdetect: Do not request arp on those ifaces where given ip is not local.
vzarpipset: Do not send arp on those ifaces where given ip is not local.
--- a/etc/vps-functions
+++ b/etc/vps-functions
@@ -119,6 +119,9 @@ vzarp()
[ -n "${NETDEVICES}" ] || vzwarning "Device list is empty"
for DEV in ${NETDEVICES}; do
+ [ "$1" = del ] ||
+ ! ${IP_CMD} route get ${2} oif ${DEV} |grep -qs ' via .* src ' ||
+ continue
${IP_CMD} neigh ${1} proxy ${2} dev ${DEV} > /dev/null 2>&1
done
}
@@ -130,14 +133,16 @@ vzarpipdetect()
local ip
local cmd
- [ -z "${1}" ] && return
+ [ -n "$1" ] || return
[ "${SKIP_ARPDETECT}" = "yes" ] && return
- for ip in ${1}; do
- cmd="$cmd -e $ip"
- done
-
for DEV in ${NETDEVICES}; do
+ for ip in ${1}; do
+ ! ${IP_CMD} route get ${ip} oif ${DEV} |grep -qs ' via .* src ' ||
+ continue
+ cmd="$cmd -e $ip"
+ done
+ [ -n "$cmd" ] || continue
${ARPSEND_CMD} -D ${cmd} ${DEV} ||
vzwarning "${ARPSEND_CMD} -D ${cmd} ${DEV} FAILED"
done
@@ -148,15 +153,17 @@ vzarpipset()
{
local DEV
local ip
- local dev
+ local cmd
- [ -z "$1" ] && return
+ [ -n "$1" ] || return
- for dev in ${NETDEVICES}; do
+ for DEV in ${NETDEVICES}; do
for ip in ${1}; do
- opt="-i ${ip} -e ${ip}"
- ${ARPSEND_CMD} -U ${opt} ${dev} ||
- vzwarning "${ARPSEND_CMD} -U ${opt} ${dev} FAILED"
+ ! ${IP_CMD} route get ${ip} oif ${DEV} |grep -qs ' via .* src ' ||
+ continue
+ cmd="-i ${ip} -e ${ip}"
+ ${ARPSEND_CMD} -U ${cmd} ${DEV} ||
+ vzwarning "${ARPSEND_CMD} -U ${cmd} ${DEV} FAILED"
done
done
}
Идея возникла в результате прочтения
https://bugzilla.altlinux.org/show_bug.cgi?id=10324
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [devel] openvz arp
2006-11-26 13:51 ` [devel] openvz arp Dmitry V. Levin
@ 2006-11-27 5:55 ` Dmitry Lebkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Lebkov @ 2006-11-27 5:55 UTC (permalink / raw)
To: ALT Devel discussion list
[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]
Dmitry V. Levin wrote:
> On Thu, Sep 21, 2006 at 02:33:34PM +0400, Dmitry V. Levin wrote:
>> On Thu, Sep 21, 2006 at 10:07:37AM +0400, Alexey I. Froloff wrote:
>>> * Dmitry V. Levin <ldv@> [060920 20:37]:
>>>> Можно, конечно, но на месте upstream'а я бы завёл список ip-адресов,
>>>> которые не нужно проверять vzarpipdetect'ом, и список ip-адресов, которые
>>>> не нужно анонсировать vzarpipset'ом и vzarp'ом.
>>> А где держать этот список и в каком виде? Что-то типа
>>> ARP_SKIP_DETECT/ARP_SKIP_ANNOUNCE со списком подсетей в
>>> /etc/sysconfig/vz ?
>> Да, я думаю предложить им такое.
>
> Я передумал и теперь предполагаю сделать так:
>
> vzarp: When adding ip, do not announce it on those ifaces where it is not local.
> vzarpipdetect: Do not request arp on those ifaces where given ip is not local.
> vzarpipset: Do not send arp on those ifaces where given ip is not local.
> --- a/etc/vps-functions
> +++ b/etc/vps-functions
> @@ -119,6 +119,9 @@ vzarp()
>
> [ -n "${NETDEVICES}" ] || vzwarning "Device list is empty"
> for DEV in ${NETDEVICES}; do
> + [ "$1" = del ] ||
> + ! ${IP_CMD} route get ${2} oif ${DEV} |grep -qs ' via .* src ' ||
> + continue
> ${IP_CMD} neigh ${1} proxy ${2} dev ${DEV} > /dev/null 2>&1
> done
> }
> @@ -130,14 +133,16 @@ vzarpipdetect()
> local ip
> local cmd
>
> - [ -z "${1}" ] && return
> + [ -n "$1" ] || return
> [ "${SKIP_ARPDETECT}" = "yes" ] && return
>
> - for ip in ${1}; do
> - cmd="$cmd -e $ip"
> - done
> -
> for DEV in ${NETDEVICES}; do
> + for ip in ${1}; do
> + ! ${IP_CMD} route get ${ip} oif ${DEV} |grep -qs ' via .* src ' ||
> + continue
> + cmd="$cmd -e $ip"
> + done
> + [ -n "$cmd" ] || continue
> ${ARPSEND_CMD} -D ${cmd} ${DEV} ||
> vzwarning "${ARPSEND_CMD} -D ${cmd} ${DEV} FAILED"
> done
> @@ -148,15 +153,17 @@ vzarpipset()
> {
> local DEV
> local ip
> - local dev
> + local cmd
>
> - [ -z "$1" ] && return
> + [ -n "$1" ] || return
>
> - for dev in ${NETDEVICES}; do
> + for DEV in ${NETDEVICES}; do
> for ip in ${1}; do
> - opt="-i ${ip} -e ${ip}"
> - ${ARPSEND_CMD} -U ${opt} ${dev} ||
> - vzwarning "${ARPSEND_CMD} -U ${opt} ${dev} FAILED"
> + ! ${IP_CMD} route get ${ip} oif ${DEV} |grep -qs ' via .* src ' ||
> + continue
> + cmd="-i ${ip} -e ${ip}"
> + ${ARPSEND_CMD} -U ${cmd} ${DEV} ||
> + vzwarning "${ARPSEND_CMD} -U ${cmd} ${DEV} FAILED"
> done
> done
> }
>
> Идея возникла в результате прочтения
> https://bugzilla.altlinux.org/show_bug.cgi?id=10324
В аттаче - работающий вариант вышеописанной идеи (если я ее правильно понял). ;)
--
WBR, Dmitry Lebkov
[-- Attachment #2: vps-functions.patch --]
[-- Type: text/plain, Size: 2698 bytes --]
--- vps-functions.orig 2006-11-27 13:49:37 +1000
+++ vps-functions 2006-11-27 15:52:56 +1000
@@ -115,12 +115,17 @@ vzgetnetdev()
# $NETDEVICES - Network devices used to take MAC addresses from
vzarp()
{
- local DEV
+ local src_addr
+ local src_dev
[ -n "${NETDEVICES}" ] || vzwarning "Device list is empty"
- for DEV in ${NETDEVICES}; do
- ${IP_CMD} neigh ${1} proxy ${2} dev ${DEV} > /dev/null 2>&1
- done
+ src_addr=`ip route get ${2} | awk -F 'src ' '{print $2; exit}'`
+ if [ -n "${src_addr}" ]; then
+ src_dev=`ip route list ${src_addr} scope host table local | awk '{print $4; exit}'`
+ if [ -n "${src_dev}" ]; then
+ ${IP_CMD} neigh ${1} proxy ${2} dev ${src_dev} > /dev/null 2>&1
+ fi
+ fi
}
# Send ARP request to detect that somebody already have this IP
@@ -130,16 +135,18 @@ vzarpipdetect()
local ip
local cmd
- [ -z "${1}" ] && return
+ [ -n "$1" ] || return
[ "${SKIP_ARPDETECT}" = "yes" ] && return
- for ip in ${1}; do
- cmd="$cmd -e $ip"
- done
-
for DEV in ${NETDEVICES}; do
- ${ARPSEND_CMD} -D ${cmd} ${DEV} ||
- vzwarning "${ARPSEND_CMD} -D ${cmd} ${DEV} FAILED"
+ for ip in ${1}; do
+ ! ${IP_CMD} route get ${ip} oif ${DEV} |grep -qs ' via .* src ' ||
+ continue
+ cmd="-e $ip"
+ [ -n "$cmd" ] || continue
+ ${ARPSEND_CMD} -D ${cmd} ${DEV} ||
+ vzwarning "${ARPSEND_CMD} -D ${cmd} ${DEV} FAILED"
+ done
done
}
@@ -148,16 +155,21 @@ vzarpipset()
{
local DEV
local ip
- local dev
+ local cmd
+ local src_addr
- [ -z "${1}" ] && return
+ [ -n "$1" ] || return
- for dev in ${NETDEVICES}; do
- for ip in ${1}; do
- opt="-i ${ip} -e ${ip}"
- ${ARPSEND_CMD} -U ${opt} ${dev} ||
- vzwarning "${ARPSEND_CMD} -U ${opt} ${dev} FAILED"
- done
+ for ip in ${1}; do
+ src_addr=`ip route get ${ip} | awk -F 'src ' '{print $2; exit}'`
+ if [ -n "${src_addr}" ]; then
+ DEV=`ip route list ${src_addr} scope host table local | awk '{print $4; exit}'`
+ if [ -n "${DEV}" ]; then
+ cmd="-i ${ip} -e ${ip}"
+ ${ARPSEND_CMD} -U ${cmd} ${DEV} ||
+ vzwarning "${ARPSEND_CMD} -U ${cmd} ${DEV} FAILED"
+ fi
+ fi
done
}
@@ -171,9 +183,10 @@ vzaddrouting()
if ! ${IP_CMD} route list ${1} | grep "$1 dev venet0" > /dev/null 2>&1; then
if [ -n "${VE_ROUTE_SRC_DEV}" ]; then
device="dev ${VE_ROUTE_SRC_DEV}"
+ src_addr=`ip route get ${1} oif ${device} | awk -F 'src ' '{print $2; exit}'`
+ else
+ src_addr=`ip route get ${1} | awk -F 'src ' '{print $2; exit}'`
fi
- src_addr=`ip route list table local ${device} | grep '^local' |
- cut -d' ' -f2 | grep -v '^127\.' | head -n 1`
if [ -z "${src_addr}" ]; then
vzerror "Unable to get source ip [${device}]" ${VZ_CANT_ADDIP}
fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-27 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-26 13:51 ` [devel] openvz arp Dmitry V. Levin
2006-11-27 5:55 ` Dmitry Lebkov
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git