From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avm@altlinux.ru>
Message-ID: <446B94B4.8030900@altlinux.ru>
Date: Thu, 18 May 2006 01:25:08 +0400
From: "Alex V. Myltsev" <avm@altlinux.ru>
User-Agent: Thunderbird 1.5 (X11/20060328)
MIME-Version: 1.0
To: ALT Devel discussion list <devel@lists.altlinux.org>
References: <20060514124220.92CC1B132D@basalt.office.altlinux.org>	<446B7D20.2040902@altlinux.ru>	<446B83CC.5040606@altlinux.ru>
	<446B8F16.3070507@altlinux.ru>
In-Reply-To: <446B8F16.3070507@altlinux.ru>
X-Enigmail-Version: 0.94.0.0
Content-Type: multipart/mixed; boundary="------------060102090608060409030007"
Subject: Re: [devel] torsmo-0.18-alt2: rebuild failed [14]
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.7
Precedence: list
Reply-To: ALT Devel discussion list <devel@lists.altlinux.org>
List-Id: ALT Devel discussion list <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 17 May 2006 21:25:09 -0000
Archived-At: <http://lore.altlinux.org/devel/446B94B4.8030900@altlinux.ru/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

This is a multi-part message in MIME format.
--------------060102090608060409030007
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 8bit

Ilya wrote:
>> лично у меня при запуске падает.
> Так она не падает, она /sys ищет
/sys она искала, это да, но она всё-таки падала.
Был типичный buffer overflow: в open_i2c_sensor был буфер buf размером
64 байта, а в get_first_file_* ожидали буфера размером 256 (и делали в
него strncpy).
Люди! Не пишите на C.


--------------060102090608060409030007
Content-Type: text/plain;
 name="torsmo-0.18-alt-memory.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="torsmo-0.18-alt-memory.patch"

--- torsmo-0.18/linux.c	2004-12-22 00:20:07 +0300
+++ torsmo-0.18.avm/linux.c	2006-05-18 01:18:05 +0400
@@ -302,7 +302,7 @@
 
 int open_i2c_sensor(const char *dev, const char *type, int n, int *div) {
   char path[256];
-  char buf[64];
+  char buf[256];
   int fd;
   int divfd;
 

--------------060102090608060409030007--