From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.1 X-Yandex-Fwd: 2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1653064198; bh=ct1yUFm7ywuItdigy6Rx+q49b3qEEnp//p78SMMhjtc=; h=Reply-To:In-Reply-To:References:Date:Subject:Cc:To:From: Message-Id; b=PjyIPE5UT7VvAf2/nUvcHKX3hraXvLqf1bquwLrN6SVESPOVAa+fs/V0j6ad/n1Bz R/7Lank1icW95+E6xLMYEx18Qa4sFFGIzjugz6FK8SFG1KIFY/aM20mpbqyhXT88ov VictJD5q2LpcZVDH9EKXFZ0Ttyi3Z50OiZS8iMlk= Authentication-Results: sas1-6b94a3a85f37.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru From: asheplyakov@yandex.ru To: devel@lists.altlinux.org Date: Fri, 20 May 2022 20:28:33 +0400 Message-Id: <20220520162849.1554351-20-asheplyakov@yandex.ru> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520162849.1554351-1-asheplyakov@yandex.ru> References: <20220520162849.1554351-1-asheplyakov@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Vitaly Chikunov , Igor Chudov , Alexey Sheplyakov , Evgeny Sinelnikov Subject: [devel] [PATCH 19/35] drm/panfrost: forcibly set dma-coherent on Baikal-M X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 16:30:17 -0000 Archived-At: List-Archive: List-Post: From: Alexey Sheplyakov With memattr 0x888d88 (set by arm_mali_lpae_alloc_pgtable) GPU (Mali T628 r1p0) experiences a lot of DATA_INVALID faults, unhandled page faults, and other errors. Also the screen goes black almost immediately. On the other hand with memattr 0x484d48 (as set by mali_kbase) the GPU appears to work just fine. Robin Murphy explains: > using the outer-cacheable attribute is deliberate because it is necessary > for I/O-coherent GPUs to work properly (and should be irrelevant for > non-coherent integrations) > I'd note that panfrost has been working OK - to the extent that Mesa > supports its older ISA - on the T624 (single core group) in Arm's > Juno SoC for over a year now since commit 268af50f38b1. > If you have to force outer non-cacheable to avoid getting translation > faults and other errors that look like the GPU is inexplicably seeing > the wrong data, I'd check whether you have the same thing where your > integration is actually I/O-coherent and you're missing the "dma-coherent" > property in your DT. Indeed setting the "gpu-coherent" property (and adjusting jobs affinity for dual core group GPU) makes panfrost work just fine on Baikal-M. However on Baikal-M the FDT is passed to the kernel by the firmware, and replacing the FDT in the firmware is tricky. Therefore set `coherent` property when running on Baikal-M (even if the `dma-coherent` property is missing in the FDT). X-DONTUPSTREAM X-feature-Baikal-M --- drivers/gpu/drm/panfrost/panfrost_drv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 96bb5a465627..8752bffbac98 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -561,6 +561,10 @@ static int panfrost_probe(struct platform_device *pdev) return -ENODEV; pfdev->coherent = device_get_dma_attr(&pdev->dev) == DEV_DMA_COHERENT; + if (!pfdev->coherent && of_device_is_compatible(of_root, "baikal,baikal-m")) { + pfdev->coherent = true; + dev_warn(&pdev->dev, "marking as DMA coherent on BE-M1000"); + } /* Allocate and initialze the DRM device. */ ddev = drm_dev_alloc(&panfrost_drm_driver, &pdev->dev); -- 2.32.0