ALT Linux Team development discussions
 help / color / mirror / Atom feed
From: Arseny Maslennikov <arseny@altlinux.org>
To: devel@lists.altlinux.org
Cc: Arseny Maslennikov <arseny@altlinux.org>
Subject: [devel] [PATCH hasher-priv v3 2/7] sockets: xsendmsg: get rid of SIGPIPE on socket writes
Date: Tue, 24 Aug 2021 11:24:31 +0300
Message-ID: <20210824082436.1555890-3-arseny@altlinux.org> (raw)
In-Reply-To: <20210824082436.1555890-1-arseny@altlinux.org>

In the daemon, we do not want to receive SIGPIPE and very much prefer to
handle emerging communication errors ourselves.

In the client, SIGPIPE is a bit more bearable. It prevents logging to
stderr, though, so we'd like to avoid that as well.

Signed-off-by: Arseny Maslennikov <arseny@altlinux.org>
---
 hasher-priv/sockets.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hasher-priv/sockets.c b/hasher-priv/sockets.c
index baad57e..3451627 100644
--- a/hasher-priv/sockets.c
+++ b/hasher-priv/sockets.c
@@ -137,7 +137,7 @@ xsendmsg(int conn, void *data, size_t len)
 	msg.msg_iov = &iov;
 	msg.msg_iovlen = 1;
 
-	ssize_t n = sendmsg_retry(conn, &msg, 0);
+	ssize_t n = sendmsg_retry(conn, &msg, MSG_NOSIGNAL);
 
 	if (n != (ssize_t) len) {
 		if (n < 0)
-- 
2.32.0



  parent reply	other threads:[~2021-08-24  8:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  8:24 [devel] [PATCH hasher-priv v3 0/7] hasher-privd Arseny Maslennikov
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 1/7] Turn hasher-priv into a daemon Arseny Maslennikov
2021-08-24  8:24 ` Arseny Maslennikov [this message]
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 3/7] chrootuid: explicitly reset signal mask before forking off payload Arseny Maslennikov
2021-12-01 19:23   ` Dmitry V. Levin
2021-12-03 15:03     ` Arseny Maslennikov
2021-12-03 16:06       ` Dmitry V. Levin
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 4/7] Link with libsetproctitle by Dmitry V. Levin Arseny Maslennikov
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 5/7] daemon: set titles for subprocesses Arseny Maslennikov
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 6/7] Add systemd and sysvinit service files Arseny Maslennikov
2021-08-24  8:24 ` [devel] [PATCH hasher-priv v3 7/7] Install hasher-priv without set ugids Arseny Maslennikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824082436.1555890-3-arseny@altlinux.org \
    --to=arseny@altlinux.org \
    --cc=devel@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux Team development discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
		devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
	public-inbox-index devel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git