ALT Linux Team development discussions
 help / color / mirror / Atom feed
From: Alexey Gladkov <legion@altlinux.ru>
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Subject: Re: [devel] gear-rules: allow backslashes to escape any characters
Date: Wed, 9 Dec 2020 16:51:57 +0100
Message-ID: <20201209155157.5lg7qarrgdh5gia4@example.org> (raw)
In-Reply-To: <20201209143942.GA13405@altlinux.org>

On Wed, Dec 09, 2020 at 05:39:42PM +0300, Dmitry V. Levin wrote:
> On Wed, Dec 09, 2020 at 11:40:15AM +0100, Alexey Gladkov wrote:
> > On Wed, Dec 09, 2020 at 05:10:04AM +0300, Dmitry V. Levin wrote:
> > > On Thu, Nov 26, 2020 at 04:51:50PM +0100, Alexey Gladkov wrote:
> > > > On Thu, Nov 26, 2020 at 04:17:01PM +0100, Alexey Gladkov wrote:
> [...]
> > > > > Если хотите увеличить читабильность, то давайте реализуем многострочные
> > > > > директивы. Тогда можно будет написать:
> > > > > 
> > > > > 	tar: v@version@:.
> > > > > 	diff: v@version@:. . \
> > > > > 		name=@new_dir@-@version@-@release@.patch \
> > > > > 		exclude=.gear
> > > > 
> > > > Быстрый патч, который позволит сделать такое. Нужно проверить не сломаются
> > > > ли какие-нибудь gear-rules.
> > > 
> > > По крайней мере в Сизифе gear-rules, содержащих символ "\", не обнаружено.
> > > 
> > > > Signed-off-by: Alexey Gladkov <legion@altlinux.org>
> > > 
> > > Это хорошо, но в gear-rules(5) сейчас сказано буквально следующее:
> > > "There is no support for line continuation."
> > > 
> > > Так что documentation update и commit message тоже нужны. :)
> > 
> > Так это был набросок, а не патч ))) Ок, сделаю из него настоящий патч.
> 
> Вопрос в том, действительно ли мы хотим эту фичу,
> которая по сути allows backslashes to escape any characters.

C одной стороны, да это сильно расширяет, но с другой стороны можно
вынести valid_string из if'a и проверить все options [1].

[1] http://git.altlinux.org/people/ldv/packages/gear.git?p=gear.git;a=blob;f=gear;h=340321465f695449a28e8b5efcedfec7acbca2ab;hb=HEAD#l586

-- 
Rgrds, legion



  parent reply	other threads:[~2020-12-09 15:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 14:16 [devel] [PATCH 1/3] Introduce nodiff directive for gear-rules Vladimir D. Seleznev
2020-11-26 14:16 ` [devel] [PATCH 2/3] tests: add test for nodiff directive Vladimir D. Seleznev
2020-11-26 14:16 ` [devel] [PATCH 3/3] tests: check nodiff does not fail if pattern matches no file Vladimir D. Seleznev
2020-11-26 14:49 ` [devel] [PATCH 1/3] Introduce nodiff directive for gear-rules Alexey Gladkov
2020-11-26 14:54   ` Vladimir D. Seleznev
2020-11-26 15:17     ` Alexey Gladkov
2020-11-26 15:20       ` Anton Farygin
2020-11-26 15:51       ` Alexey Gladkov
2020-12-09  2:10         ` Dmitry V. Levin
2020-12-09 10:40           ` Alexey Gladkov
2020-12-09 14:39             ` [devel] gear-rules: allow backslashes to escape any characters Dmitry V. Levin
2020-12-09 14:48               ` Vladimir D. Seleznev
2020-12-09 15:51               ` Alexey Gladkov [this message]
2020-12-10 10:31                 ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209155157.5lg7qarrgdh5gia4@example.org \
    --to=legion@altlinux.ru \
    --cc=devel@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux Team development discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
		devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
	public-inbox-index devel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git