From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <legion@altlinux.ru>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
 autolearn=unavailable autolearn_force=no version=3.4.1
Date: Mon, 7 Dec 2020 18:29:13 +0100
From: Alexey Gladkov <legion@altlinux.ru>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Message-ID: <20201207172913.artgjib3dcyxtfv4@example.org>
References: <20201127134431.3854941-1-vseleznv@altlinux.org>
 <20201207165809.GA13984@altlinux.org>
 <20201207170741.rfnoiuojeaq427ii@example.org>
 <20201207171925.GB13984@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201207171925.GB13984@altlinux.org>
Cc: devel@lists.altlinux.org, "Vladimir D. Seleznev" <vseleznv@altlinux.org>
Subject: Re: [devel] [PATCH v4 1/2] Add diff exclude option for gear-rules
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2020 17:29:21 -0000
Archived-At: <http://lore.altlinux.org/devel/20201207172913.artgjib3dcyxtfv4@example.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Mon, Dec 07, 2020 at 08:19:25PM +0300, Dmitry V. Levin wrote:
> On Mon, Dec 07, 2020 at 06:07:41PM +0100, Alexey Gladkov wrote:
> > On Mon, Dec 07, 2020 at 07:58:09PM +0300, Dmitry V. Levin wrote:
> > > On Fri, Nov 27, 2020 at 04:44:30PM +0300, Vladimir D. Seleznev wrote:
> [...]
> > > > @@ -376,6 +376,13 @@ get_diff_name()
> > > >  				;;
> > > >  			name=*) diff_name="${opt#name=}"
> > > >  				;;
> > > > +			exclude=*)
> > > > +				[ -z "$(printf %s "${opt#exclude=}" |tr -d '[:alnum:]_.?*-/![]')" ] ||
> > > > +					rules_error "Invalid diff exclude pattern specified: ${opt#exclude=}"
> > > 
> > > Why '[:alnum:]_.?*-/![]' ?
> > 
> > because glob patterns have these symbols.
> 
> This doesn't match the pattern check in extract_pattern(),
> should it be updated?

This is a different issue. I told you about this on November 26, 2020.

> Would it be useful to have a single definition of this set somewhere?

Yep.

-- 
Rgrds, legion