From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 Date: Fri, 2 Oct 2020 02:42:55 +0200 From: Alexey Gladkov To: ALT Linux Team development discussions Message-ID: <20201002004255.ejhzsfpaijn5yzxj@comp-core-i7-2640m-0182e6> References: <2dd521b85103ae35347e548c89b6873a80811206.1576183643.git.legion@altlinux.org> <20200917131107.GE286846@cello> <20201001191733.tb5kgjn6ylpxlg5t@comp-core-i7-2640m-0182e6> <20201001202353.GC1037402@cello> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c7vq5ugl327oqbg2" Content-Disposition: inline In-Reply-To: <20201001202353.GC1037402@cello> Cc: ldv@altlinux.org Subject: Re: [devel] [PATCH hasher-priv v1 3/3] Add cgroup support X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 00:43:03 -0000 Archived-At: List-Archive: List-Post: --c7vq5ugl327oqbg2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 01, 2020 at 11:23:53PM +0300, Arseny Maslennikov wrote: > > > Could you please explain what you're trying to do with this patch? > > > Even if it's obvious from the source itself, we still must have an > > > opportunity to discuss, and a decent explanation should stay in the > > > project history. > >=20 > > I think this patch is simple enough. >=20 > There's a misunderstanding here. I'm not asking to explain the > semantics (what this patch does) =E2=80=94 I repeat, it's rather obvious = =66rom > the source itself, the patch is indeed simple. I'm trying to get how the > patch's author would describe the pragmatic value of this patch. IOW: > we see this patch does XXX. What, in Alexey's view, are we trying to > achieve by implementing XXX? I remember that this patch was the result of a discussion with ldv. I didn't want to add complex support for different versions of cgroups. The idea was that the admin would prepare the system for use of cgroups by the hasher-privd daemon. I'm not considering the hasher-privd as an end user server. This is a low-level server on which you can build different solutions. I don't mean just hasher. With this in mind, I don't think that this server should do everything out of the box without configuration. Does this make sense to you? > Descriptive commit messages are done (and are enforced in successful > communities, e. g. LKML) for a reason. >=20 > The above essentially is my previous comment here, reworded and clarified. >=20 > If for some reason you believe it's shameful or rude to the community to > "waste time" on textual explanations, fair enough =E2=80=94 I'll maybe wr= ite a commit > message myself (with my take on why this might be useful) and then most > likely ACK the same patch, with authorship reattributed to you via From: > in the patch body and the new commit message. Or else NAK this > particular revision with an empty commit message and leave it up to > ldv@. > If it were up to me, I would not approve of empty commit messages in a > lasting, crucial project like hasher-privd. People are forgetful, and > commit messages exist to help. Ok. > > > Do we only support cgroup2 and ignore cgroup1? If yes, great, but > > > perhaps then we might want to have a setting to not fiddle with cgroup > > > trees, to support the unfortunate users that have to run Docker and > > > other garbage. > >=20 > > Yeah, I didn't plan on supporting legacy version of cgroups. Docker > > already can work with cgroupsv2. >=20 > Oh, I heard they were just recently working on cgroup2 support. https://github.com/opencontainers/runc/blob/master/docs/cgroup-v2.md --=20 Rgrds, legion --c7vq5ugl327oqbg2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSuzIk+w2aWgaEZLHKOFEXcaOMeVAUCX3Z3jwAKCRCOFEXcaOMe VPeSAKCJD8QKVIzVfsE/XTMjyv98jVqkeQCfa0KuhqbHzZGAjIn4ZnusaKR1X0Y= =l4as -----END PGP SIGNATURE----- --c7vq5ugl327oqbg2--