From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vseleznv@altlinux.org>
Date: Tue, 21 Jul 2020 15:15:12 +0300
From: "Vladimir D. Seleznev" <vseleznv@altlinux.org>
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Message-ID: <20200721121512.GA2406014@portlab>
References: <20200720225458.2391145-1-vseleznv@altlinux.org>
 <20200720230031.2391597-1-vseleznv@altlinux.org>
 <20200721114926.GA17962@altlinux.org>
 <20200721115726.GA2404990@portlab>
 <20200721120216.GB17962@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200721120216.GB17962@altlinux.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [devel] [PATCH] gb-task-check-noarch-i: check package scriptlets
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2020 12:15:13 -0000
Archived-At: <http://lore.altlinux.org/devel/20200721121512.GA2406014@portlab/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Tue, Jul 21, 2020 at 03:02:16PM +0300, Dmitry V. Levin wrote:
> On Tue, Jul 21, 2020 at 02:57:26PM +0300, Vladimir D. Seleznev wrote:
> > On Tue, Jul 21, 2020 at 02:49:27PM +0300, Dmitry V. Levin wrote:
> > > On Tue, Jul 21, 2020 at 02:00:31AM +0300, Vladimir D. Seleznev wrote:
> > > > noarch packages should have equal scriptlets across all arches.
> > > > New function dump_scriptlets() prints contents of RPM package scriptlets.
> > > > 
> > > > * dump_scriptlets(): New function.
> > > > * dump_noarch(): Use dump_scriptlets().
> > > > * dump_arch(): Use dump_scriptlets().
> > > > 
> > > > Reported-by: Ivan Zakharyaschev <imz@altlinux.org>
> > > > ---
> > > >  gb/gb-task-check-noarch-i | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/gb/gb-task-check-noarch-i b/gb/gb-task-check-noarch-i
> > > > index 2e38b6c..2527c84 100755
> > > > --- a/gb/gb-task-check-noarch-i
> > > > +++ b/gb/gb-task-check-noarch-i
> > > > @@ -79,10 +79,20 @@ dump_deps()
> > > >  	rpmquery --qf "$R$P$O$C" -p "$1"
> > > >  }
> > > >  
> > > > +dump_scriptlets()
> > > > +{
> > > > +	for rpmtag in POSTIN POSTINPROG POSTUN POSTUNPROG PREIN PREINPROG PREUN PREUNPROG; do
> > > 
> > > $ rpmquery --querytags |grep 'PROG$' |wc -l
> > > 10
> > 
> > А они все нужны? Большинство из них не используются. Добавлю не
> > достающие.
> 
> Хорошо бы не забыть парные им
> $ rpmquery --querytags |sed -n '/PROG$/{s///p;s/$/S/p}' |sort |comm -12 - <(rpmquery --querytags |sort) |wc -l
> 10

Я просто не уверен, что они все нужны. Из нужных отсутствуют разве что
TRIGGERSCRIPTS и TRIGGERSCRIPTPROG.

-- 
   WBR,
   Vladimir D. Seleznev