Re: [devel] [PATCH] gb-task-check-noarch-i: check package scriptlets

["Vladimir D. Seleznev" <vseleznv@altlinux.org>]

On Tue, Jul 21, 2020 at 03:02:16PM +0300, Dmitry V. Levin wrote:
> On Tue, Jul 21, 2020 at 02:57:26PM +0300, Vladimir D. Seleznev wrote:
> > On Tue, Jul 21, 2020 at 02:49:27PM +0300, Dmitry V. Levin wrote:
> > > On Tue, Jul 21, 2020 at 02:00:31AM +0300, Vladimir D. Seleznev wrote:
> > > > noarch packages should have equal scriptlets across all arches.
> > > > New function dump_scriptlets() prints contents of RPM package scriptlets.
> > > > 
> > > > * dump_scriptlets(): New function.
> > > > * dump_noarch(): Use dump_scriptlets().
> > > > * dump_arch(): Use dump_scriptlets().
> > > > 
> > > > Reported-by: Ivan Zakharyaschev <imz@altlinux.org>
> > > > ---
> > > >  gb/gb-task-check-noarch-i | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/gb/gb-task-check-noarch-i b/gb/gb-task-check-noarch-i
> > > > index 2e38b6c..2527c84 100755
> > > > --- a/gb/gb-task-check-noarch-i
> > > > +++ b/gb/gb-task-check-noarch-i
> > > > @@ -79,10 +79,20 @@ dump_deps()
> > > >  	rpmquery --qf "$R$P$O$C" -p "$1"
> > > >  }
> > > >  
> > > > +dump_scriptlets()
> > > > +{
> > > > +	for rpmtag in POSTIN POSTINPROG POSTUN POSTUNPROG PREIN PREINPROG PREUN PREUNPROG; do
> > > 
> > > $ rpmquery --querytags |grep 'PROG$' |wc -l
> > > 10
> > 
> > А они все нужны? Большинство из них не используются. Добавлю не
> > достающие.
> 
> Хорошо бы не забыть парные им
> $ rpmquery --querytags |sed -n '/PROG$/{s///p;s/$/S/p}' |sort |comm -12 - <(rpmquery --querytags |sort) |wc -l
> 10

Я просто не уверен, что они все нужны. Из нужных отсутствуют разве что
TRIGGERSCRIPTS и TRIGGERSCRIPTPROG.

-- 
   WBR,
   Vladimir D. Seleznev