From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 Date: Sun, 14 Jun 2020 01:30:01 +0300 From: Andrey Savchenko To: ALT Linux Team development discussions Message-Id: <20200614013001.902db51579d5f9714fb045dc@altlinux.org> In-Reply-To: <20200613211049.GC24260@altlinux.org> References: <20200604195811.3881130-1-vseleznv@altlinux.org> <20200604195811.3881130-2-vseleznv@altlinux.org> <20200605142254.GA4019241@portlab> <20200613174519.GB22306@altlinux.org> <20200613215037.8df524060960dbf33fd37479@altlinux.org> <20200613204838.GA24260@altlinux.org> <20200613235708.bb042fff7f3dd9c7a885a72b@altlinux.org> <20200613211049.GC24260@altlinux.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Sun__14_Jun_2020_01_30_02_+0300_8536XB0G+YDmz9.9" Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2020 22:30:11 -0000 Archived-At: List-Archive: List-Post: --Signature=_Sun__14_Jun_2020_01_30_02_+0300_8536XB0G+YDmz9.9 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, 14 Jun 2020 00:10:49 +0300 Dmitry V. Levin wrote: > On Sat, Jun 13, 2020 at 11:57:08PM +0300, Andrey Savchenko wrote: > > On Sat, 13 Jun 2020 23:48:38 +0300 Dmitry V. Levin wrote: > > > On Sat, Jun 13, 2020 at 09:50:37PM +0300, Andrey Savchenko wrote: > > > > On Sat, 13 Jun 2020 20:45:19 +0300 Dmitry V. Levin wrote: > > > > > On Sat, Jun 06, 2020 at 04:42:21PM +0300, Alexey Tourbin wrote: > > > > > > On Fri, Jun 5, 2020 at 5:23 PM Vladimir D. Seleznev wrote: > > > > > > > > > Introduce task post-build processing. It finds subtasks w= ith package > > > > > > > > > rebuild and if the rebuilt packages identical to the same= packages in > > > > > > > > > the target repo it optimizes them. > > > > > > > > > > > > > > > > It doesn't make much sense. When we rebuild a package witho= ut changing > > > > > > > > the release, we expect something else in the package to cha= nge because > > > > > > > > of the rebuild (e.g. a binary will be linked with a new lib= rary > > > > > > > > version). If the package hasn't changed, it is an alarming = condition > > > > > > > > which indicates that some of the packager's assumptions wer= e wrong > > > > > > > > (e.g. the binary actually doesn't link with the library). S= o should we > > > > > > > > really "optimize" this case? We might as well prohibit it! > > > > > > > > > > > > > > By "prohibit" you mean make task build fail? I would say that= it is > > > > > > > unnecessary. It'd produce additional difficulties for maintai= ners > > > > > > > without any profit. > > > > > >=20 > > > > > > The difficulties are all in the maintainers' heads. > > > > > > There must be a valid reason for rebuilding a package. > > > > >=20 > > > > > Given that rebuilding a package costs so little for the maintaine= r, > > > > > we definitely should reject rebuilds that do not result to changed > > > > > packages. > > > >=20 > > > > There are valid cases when it is impossible to determine beforehand > > > > if rebuild will result in changed package or not, e.g. during boost > > > > updates. > > >=20 > > > So what? Failed build is not a crime, let it fail. > >=20 > > Intentionally wasted maintainer's time is a huge crime. Let a > > machine work instead of a human, this way we can be more productive. >=20 > I suppose packages are built for a reason, so every unchanged build > must be a mistake, and I read this as an argument to fail such builds. Filter them out automatically if you can, keep them if you can't. But wasting human time for such type of work is nonsense and should not be allowed. Best regards, Andrew Savchenko --Signature=_Sun__14_Jun_2020_01_30_02_+0300_8536XB0G+YDmz9.9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE63ZIHsdeM+1XgNer9lNaM7oe5I0FAl7lU2oACgkQ9lNaM7oe 5I1JfRAAkzVEmyremvXW2GUcso493Lcpze/2sijY8mgdYUkADQyqRaPPJof8XP0B /I4barn3/ax9lZ9F0f93CsV98k0pQ55U1Ml3ObvX/QrtUpaZp9lUS2CNbmcMVm31 R3R5oX6WrhNdGexk0aXBdV2Hldbb/DZFoyXf7u+aztOhh/bgc4CVf2lRpU6K9+Ms 9s03NDZwL/Cl3tTkuBbz3bMt8KEoZN33d3qKIU5PoVGD546+F2rPBYmGtzRGl/5o YLi+nOBYdzkLFhXABRTAezc8cqMYC0gkEc9CHQD++2a6rBeH1y+WK6DmDPEIoxKU Nh/5Y17eR1ZkTSYuxoPnLS2OgqW+gH8U0PuH6qmptqP6YTsQVYtdVH9dKKHlieOT 8pD8iCLv2pCI5+RshB3UW14mZgtvRMf52CV/v5Yr8zdrTsw9kNdKltbgEnNPipX0 65CsVV4SgklcIo0S42GiesZwpTbnZSxx3JM/X7kOSmFzY8fkBSciF19UyzJXwiDI NBMnfMaPmQUsiV0hNMezLAov1jYKhQd0w3u3LTieehsNyuBDm7OQ4oY8zXXONMTL oD6sVtCghgB/wWP1gdz4zYX5BAtpHSPPPPxosfsjPs3i33V9uYjRiMqq/HmbWoXL f6siWUz0GsjJpxNhqGlexGSABqjqYq3vFPnlH/f1p1nqSxbUV5Y= =4t7H -----END PGP SIGNATURE----- --Signature=_Sun__14_Jun_2020_01_30_02_+0300_8536XB0G+YDmz9.9--