From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 Date: Sat, 13 Jun 2020 23:57:08 +0300 From: Andrey Savchenko To: ALT Linux Team development discussions Message-Id: <20200613235708.bb042fff7f3dd9c7a885a72b@altlinux.org> In-Reply-To: <20200613204838.GA24260@altlinux.org> References: <20200604195811.3881130-1-vseleznv@altlinux.org> <20200604195811.3881130-2-vseleznv@altlinux.org> <20200605142254.GA4019241@portlab> <20200613174519.GB22306@altlinux.org> <20200613215037.8df524060960dbf33fd37479@altlinux.org> <20200613204838.GA24260@altlinux.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Sat__13_Jun_2020_23_57_08_+0300_w/DEcgKw7IYi0UHP" Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2020 20:57:39 -0000 Archived-At: List-Archive: List-Post: --Signature=_Sat__13_Jun_2020_23_57_08_+0300_w/DEcgKw7IYi0UHP Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, 13 Jun 2020 23:48:38 +0300 Dmitry V. Levin wrote: > On Sat, Jun 13, 2020 at 09:50:37PM +0300, Andrey Savchenko wrote: > > On Sat, 13 Jun 2020 20:45:19 +0300 Dmitry V. Levin wrote: > > > On Sat, Jun 06, 2020 at 04:42:21PM +0300, Alexey Tourbin wrote: > > > > On Fri, Jun 5, 2020 at 5:23 PM Vladimir D. Seleznev wrote: > > > > > > > Introduce task post-build processing. It finds subtasks with = package > > > > > > > rebuild and if the rebuilt packages identical to the same pac= kages in > > > > > > > the target repo it optimizes them. > > > > > > > > > > > > It doesn't make much sense. When we rebuild a package without c= hanging > > > > > > the release, we expect something else in the package to change = because > > > > > > of the rebuild (e.g. a binary will be linked with a new library > > > > > > version). If the package hasn't changed, it is an alarming cond= ition > > > > > > which indicates that some of the packager's assumptions were wr= ong > > > > > > (e.g. the binary actually doesn't link with the library). So sh= ould we > > > > > > really "optimize" this case? We might as well prohibit it! > > > > > > > > > > By "prohibit" you mean make task build fail? I would say that it = is > > > > > unnecessary. It'd produce additional difficulties for maintainers > > > > > without any profit. > > > >=20 > > > > The difficulties are all in the maintainers' heads. > > > > There must be a valid reason for rebuilding a package. > > >=20 > > > Given that rebuilding a package costs so little for the maintainer, > > > we definitely should reject rebuilds that do not result to changed > > > packages. > >=20 > > There are valid cases when it is impossible to determine beforehand > > if rebuild will result in changed package or not, e.g. during boost > > updates. >=20 > So what? Failed build is not a crime, let it fail. Intentionally wasted maintainer's time is a huge crime. Let a machine work instead of a human, this way we can be more productive. Best regards, Andrew Savchenko --Signature=_Sat__13_Jun_2020_23_57_08_+0300_w/DEcgKw7IYi0UHP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE63ZIHsdeM+1XgNer9lNaM7oe5I0FAl7lPaQACgkQ9lNaM7oe 5I2L7Q//XpwfdgreAPnuW26Amy4ZgEWtfEGFW7Gp/sNKZwniqjFZCeK2wuD9Gmhy JB6t4+ARPpPa7UxqeV0LUWU9HSlqkEnyN1BDQLCVz7drX9PM5hpSnqpysq2hzjci cwy3kb7/avrD9U/phVlv1qiAnUHQNhws703UmsKjWJLnhwjWF6H3e6xSNaR2hM4O t7lNMhoXAsOC47Cz/KLqPDJQldTQhHC0Ti3ZjoPbipwz0bVL0NHrRu/fP9B7QMEn ss3t8Fd8gLJNybkBE9hoV9atOuCqLwM4ySRQlyGPkA2sTbzVWWAOE6IM+yIxJ+lU kEjlBe2WRQYT8MGIvWCqPIxQlWvWlyMUgVH88g7Hc9fhW/EZzoRrZ0dlDwASlA7Z 9VqMrj0DK9TMIeC9HrB+syRZ/yYzwc6Gp0I6fgJTrCIHsZiyNfylkP89BcSsq59r lglAbIp3rBPgN0oHm5B124qG478SzBYJJkNITPoYlh405CPvjFZTPxVbkWMOZBgs lHnCW8HhW8qdNqqu3pVhWbaA+GqvYc/DMZxTISsk+hwlU9DsEYQ+Sgcld1iLjTQo sV0I7eEztVENqQfiB74M6jcjh3vBTKBr1Wyyo6pvPrb+ouhEyCFp6J1G1GGbXesA uCAe5/vD40EzPMNg3LBal9SEGYcbOodSGOi7nnPpINW+028UDOA= =01bs -----END PGP SIGNATURE----- --Signature=_Sat__13_Jun_2020_23_57_08_+0300_w/DEcgKw7IYi0UHP--