From: "Dmitry V. Levin" <ldv@altlinux.org>
To: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild
Date: Sat, 13 Jun 2020 20:45:19 +0300
Message-ID: <20200613174519.GB22306@altlinux.org> (raw)
In-Reply-To: <CA+qzen=mqQOBRQ3box1kbhS8pnj_MWCtDOmasV6HNoTfr9orTA@mail.gmail.com>
On Sat, Jun 06, 2020 at 04:42:21PM +0300, Alexey Tourbin wrote:
> On Fri, Jun 5, 2020 at 5:23 PM Vladimir D. Seleznev wrote:
> > > > Introduce task post-build processing. It finds subtasks with package
> > > > rebuild and if the rebuilt packages identical to the same packages in
> > > > the target repo it optimizes them.
> > >
> > > It doesn't make much sense. When we rebuild a package without changing
> > > the release, we expect something else in the package to change because
> > > of the rebuild (e.g. a binary will be linked with a new library
> > > version). If the package hasn't changed, it is an alarming condition
> > > which indicates that some of the packager's assumptions were wrong
> > > (e.g. the binary actually doesn't link with the library). So should we
> > > really "optimize" this case? We might as well prohibit it!
> >
> > By "prohibit" you mean make task build fail? I would say that it is
> > unnecessary. It'd produce additional difficulties for maintainers
> > without any profit.
>
> The difficulties are all in the maintainers' heads.
> There must be a valid reason for rebuilding a package.
Given that rebuilding a package costs so little for the maintainer,
we definitely should reject rebuilds that do not result to changed
packages.
--
ldv
next prev parent reply other threads:[~2020-06-13 17:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 19:58 [devel] Optimize rebuilt subtask packages identical to the packages in the target repo Vladimir D. Seleznev
2020-06-04 19:58 ` [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild Vladimir D. Seleznev
2020-06-05 13:40 ` Alexey Tourbin
2020-06-05 14:22 ` Vladimir D. Seleznev
2020-06-06 13:42 ` Alexey Tourbin
2020-06-13 17:45 ` Dmitry V. Levin [this message]
2020-06-13 18:50 ` Andrey Savchenko
2020-06-13 20:48 ` Dmitry V. Levin
2020-06-13 20:57 ` Andrey Savchenko
2020-06-13 21:10 ` Dmitry V. Levin
2020-06-13 22:30 ` Andrey Savchenko
2020-06-13 19:32 ` Vladimir D. Seleznev
2020-06-13 21:03 ` Dmitry V. Levin
2020-06-13 22:03 ` Vladimir D. Seleznev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200613174519.GB22306@altlinux.org \
--to=ldv@altlinux.org \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git