From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 5 Jun 2020 17:22:54 +0300 From: "Vladimir D. Seleznev" To: ALT Linux Team development discussions Message-ID: <20200605142254.GA4019241@portlab> References: <20200604195811.3881130-1-vseleznv@altlinux.org> <20200604195811.3881130-2-vseleznv@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2020 14:22:55 -0000 Archived-At: List-Archive: List-Post: On Fri, Jun 05, 2020 at 04:40:52PM +0300, Alexey Tourbin wrote: > On Thu, Jun 4, 2020 at 10:58 PM Vladimir D. Seleznev > wrote: > > Introduce task post-build processing. It finds subtasks with package > > rebuild and if the rebuilt packages identical to the same packages in > > the target repo it optimizes them. > > It doesn't make much sense. When we rebuild a package without changing > the release, we expect something else in the package to change because > of the rebuild (e.g. a binary will be linked with a new library > version). If the package hasn't changed, it is an alarming condition > which indicates that some of the packager's assumptions were wrong > (e.g. the binary actually doesn't link with the library). So should we > really "optimize" this case? We might as well prohibit it! By "prohibit" you mean make task build fail? I would say that it is unnecessary. It'd produce additional difficulties for maintainers without any profit. > The packager should be cognizant that some of his efforts aren't > making any difference. :) But packager can know that this kind of effort aren't making any difference because of build log warning. And this can be convenient in case of mass rebuild, for example. P.S. This suggestion seems like a joke to me :) -- WBR, Vladimir D. Seleznev