From: "Vladimir D. Seleznev" <vseleznv@altlinux.org> To: ALT Linux Team development discussions <devel@lists.altlinux.org> Subject: Re: [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild Date: Fri, 5 Jun 2020 17:22:54 +0300 Message-ID: <20200605142254.GA4019241@portlab> (raw) In-Reply-To: <CA+qzennGrUk11WWhYdM9cn-Bcti3DRQ71Jnv_d_dg4E2eiuGEg@mail.gmail.com> On Fri, Jun 05, 2020 at 04:40:52PM +0300, Alexey Tourbin wrote: > On Thu, Jun 4, 2020 at 10:58 PM Vladimir D. Seleznev > <vseleznv@altlinux.org> wrote: > > Introduce task post-build processing. It finds subtasks with package > > rebuild and if the rebuilt packages identical to the same packages in > > the target repo it optimizes them. > > It doesn't make much sense. When we rebuild a package without changing > the release, we expect something else in the package to change because > of the rebuild (e.g. a binary will be linked with a new library > version). If the package hasn't changed, it is an alarming condition > which indicates that some of the packager's assumptions were wrong > (e.g. the binary actually doesn't link with the library). So should we > really "optimize" this case? We might as well prohibit it! By "prohibit" you mean make task build fail? I would say that it is unnecessary. It'd produce additional difficulties for maintainers without any profit. > The packager should be cognizant that some of his efforts aren't > making any difference. :) But packager can know that this kind of effort aren't making any difference because of build log warning. And this can be convenient in case of mass rebuild, for example. P.S. This suggestion seems like a joke to me :) -- WBR, Vladimir D. Seleznev
next prev parent reply other threads:[~2020-06-05 14:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 19:58 [devel] Optimize rebuilt subtask packages identical to the packages in the target repo Vladimir D. Seleznev 2020-06-04 19:58 ` [devel] [PATCH] gb: add gb-task-build-post, optimize packages with identical rebuild Vladimir D. Seleznev 2020-06-05 13:40 ` Alexey Tourbin 2020-06-05 14:22 ` Vladimir D. Seleznev [this message] 2020-06-06 13:42 ` Alexey Tourbin 2020-06-13 17:45 ` Dmitry V. Levin 2020-06-13 18:50 ` Andrey Savchenko 2020-06-13 20:48 ` Dmitry V. Levin 2020-06-13 20:57 ` Andrey Savchenko 2020-06-13 21:10 ` Dmitry V. Levin 2020-06-13 22:30 ` Andrey Savchenko 2020-06-13 19:32 ` Vladimir D. Seleznev 2020-06-13 21:03 ` Dmitry V. Levin 2020-06-13 22:03 ` Vladimir D. Seleznev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200605142254.GA4019241@portlab \ --to=vseleznv@altlinux.org \ --cc=devel@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Team development discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \ devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru public-inbox-index devel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git