From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Date: Mon, 13 Apr 2020 21:04:37 +0300
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Vladimir D. Seleznev" <vseleznv@altlinux.org>
Message-ID: <20200413180437.GC21630@altlinux.org>
References: <20200411134655.da40352c20a0e0bde65a474d@altlinux.org>
 <20200412030226.1886291-1-vseleznv@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200412030226.1886291-1-vseleznv@altlinux.org>
Cc: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH] Verbose QueryTags prints whether tag is an
 extension
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2020 18:04:37 -0000
Archived-At: <http://lore.altlinux.org/devel/20200413180437.GC21630@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Sun, Apr 12, 2020 at 06:02:26AM +0300, Vladimir D. Seleznev wrote:
> Verbose QueryTags prints four field: tagname, tagvalue, tagtype and whether
> it is an extension. To make it possible QueryTags uses new function
> rpmTagIsExtension() that returns 0 if tag is real, 1 if tag is an extension
> or -1 if tag is not found.
> 
> * lib/query.c(rpmDisplayQueryTags): Print whether tag is an extension.
> * lib/rpmtag.h(rpmTagIsExtension): New definition.
> * lib/tagname.c(rpmTagIsExtension): New function.
> ---
>  lib/query.c   |  5 +++++
>  lib/rpmtag.h  |  7 +++++++
>  lib/tagname.c | 14 ++++++++++++++
>  3 files changed, 26 insertions(+)
> 
> diff --git a/lib/query.c b/lib/query.c
> index 60d3a0269..f27b15a7c 100644
> --- a/lib/query.c
> +++ b/lib/query.c
> @@ -253,9 +253,14 @@ void rpmDisplayQueryTags(FILE * fp)
>  	if (rpmIsVerbose()) {
>  	    rpmTagVal tag = rpmTagGetValue(sname);
>  	    rpmTagType type = rpmTagGetTagType(tag);
> +	    int ext = rpmTagIsExtension(tag);
>  	    fprintf(fp, "%-20s %6d", sname, tag);
>  	    if (type > RPM_NULL_TYPE && type <= RPM_MAX_TYPE)
>  		fprintf(fp, " %s", tagTypeNames[type]);
> +	    else if (ext == 1)
> +		fprintf(fp, " -");
> +	    if (ext == 1)
> +		fprintf(fp, " ext");
>  	} else {
>  	    fprintf(fp, "%s", sname);
>  	}

This changes rpmDisplayQueryTags output in an incompatible way.


-- 
ldv