From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 11 Apr 2020 19:41:45 +0300 From: Gleb Fotengauer-Malinovskiy To: ALT Linux Team development discussions Message-ID: <20200411164145.GJ3341@glebfm.cloud.tilaa.com> References: <20200410231044.1436970-1-vseleznv@altlinux.org> <20200411110425.GG3341@glebfm.cloud.tilaa.com> <20200411152101.GA1624106@portlab> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KkUfzEtIprrm0TMY" Content-Disposition: inline In-Reply-To: <20200411152101.GA1624106@portlab> Subject: Re: [devel] RFC: girar: optimize rebuild X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 16:42:09 -0000 Archived-At: List-Archive: List-Post: --KkUfzEtIprrm0TMY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 11, 2020 at 06:21:01PM +0300, Vladimir D. Seleznev wrote: > On Sat, Apr 11, 2020 at 02:04:25PM +0300, Gleb Fotengauer-Malinovskiy wro= te: > > Hi, > >=20 > > On Sat, Apr 11, 2020 at 02:10:42AM +0300, Vladimir D. Seleznev wrote: > > >=20 > > > Hi! > > >=20 > > > The first part of rebuilt packages optimization for girar. It introdu= ces > > > pkg_identity() and simple optimization of the rebuilt sourcerpm. > >=20 > > Why do we rebuild source rpm at all when we already have one? I mean, > > when we use hasher with --query-repackage this new rebuilt source rpm is > > no better then original one. > >=20 > > I think we can always save the original source rpm when we rebuild > > a package or copy it from branch to branch (like we actually do for > > packages originally built from src.rpm-s). >=20 > I'm sorry, I was not clear. No, I think you were clear enough. Unlike me, obviously. :) > Sure when a package is built from the sourcerpm, no optimization is > required in this case as girar saves only original sourcerpm. Yes. > The different things happen when package is built > from the gear. In the case when package is rebuilt from the gear, girar > produce new source and binary rpms, and when the rebuilt task is done it > saves all these new source and binary rpms. The proposed optimization is > aimed for that case. Yes, I was talking about this same case. I think we don't need to bother with identity of src.rpm-s at all. If we build two src.rpm-s from two identical pkg.tar-s we still get equivalent src.rpm-s because in --query-repackage mode hasher uses src.rpm as a source archive (buildtime is the only read rpm tag). Moreover, if we do not store rebuilt src.rpm-s we do not need to rebuild it at all, we can use old src.rpm for rebuild and copy. --=20 glebfm --KkUfzEtIprrm0TMY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJekfNJAAoJEEyKfkRpkCv5VkAQAJX2zQTbCMbsJ8dU19O9h9RN H21H9/qVFWN9TlOxyebFXJRjyUStnp/hLc/lGwWMffrKl5TlJ65c013ePMKb0wmU AAZ4l+khlzMfl/5/fCmjgeKNqXV53iAOXhm1Pir5qKAWxHzaduKWVpnW7Hrv0V0W WWYdtDbXANRxt06pWiAkpw2igxUI/XFZtyV0gXsnqWSfpljqbsa6JOrAVBaQOpNn D0v4El7LiQE+21SaJwZfNn1WBG/BPSGjgsJHS3fijiLXgHOuO0qXi3q3LEySdVy4 JaPsvoEhzNILOU0bGfyku2/OPCIThchCvCLCd4gyYX5YL0nXuZtHxI1NZ27ej9Rc lGG1fDO8mghzw17Qs0VJtwcnpEAddGITs36JriLDNrfnWEDYZCHwEWUqSwFqMlKP EzYQ2NRO1hhFRkC6j5VfWKr2zxssNMV0r9wMYQ9+Y++O+dH6bWSrmyCm2omr9IX7 l1a1Q+X6W4w9o75t2REdhQIX5B7ughyeS4/prcz9PYuvgdzoS3L1bHF5EqQK9dmg w/1wsbYt2U9owhTWYej08JrRTKf8N2a7wRrCpCrgA/g7gQtoQGjmxKDp+/bWOAaW 7yrrc8PYgE5vlRrlVtqNF87eU8k7rTSk4K5DJ38ZIH0SvOE6Y8BtA5hCJ84ecIm+ 9sbdt4SljNuKDUIzoJKb =DawL -----END PGP SIGNATURE----- --KkUfzEtIprrm0TMY--