From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 Date: Sat, 11 Apr 2020 13:46:55 +0300 From: Andrey Savchenko To: ALT Linux Team development discussions Message-Id: <20200411134655.da40352c20a0e0bde65a474d@altlinux.org> In-Reply-To: <20200410231917.1482336-1-vseleznv@altlinux.org> References: <20200410231917.1482336-1-vseleznv@altlinux.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Sat__11_Apr_2020_13_46_55_+0300_QwsDNLunhZccokjK" Subject: Re: [devel] [PATCH] Verbose QueryTags prints whether tag is an extension X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 10:47:02 -0000 Archived-At: List-Archive: List-Post: --Signature=_Sat__11_Apr_2020_13_46_55_+0300_QwsDNLunhZccokjK Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, 11 Apr 2020 02:19:17 +0300 Vladimir D. Seleznev wrote: > Verbose QueryTags prints four field: tagname, tagvalue, tagtype and wheth= er > it is an extension. To make it possible QueryTags uses new function > rpmTagIsExtension() that return 0 if tag is real, 1 if tag is an extension > or 2 if tag is not found. [...] > diff --git a/lib/rpmtag.h b/lib/rpmtag.h > index f74b451dc..8e860f927 100644 > --- a/lib/rpmtag.h > +++ b/lib/rpmtag.h > @@ -519,6 +519,13 @@ rpmTagType rpmTagGetTagType(rpmTagVal tag); > */ > rpmTagReturnType rpmTagGetReturnType(rpmTagVal tag); > =20 > +/** \ingroup rpmtag > + * Return 0 if tag is real, 1 if tag is an extension, 2 on not found > + * @param tag tag value > + * @return 0 if tag is real, 1 if tag is an extension, 2 on not found I prpopose to change the return code semantics: rpmTagIsExtension is designed to return 3 possible values: yes, no or error. 1 is a good choise for yes, so it is OK 0 is a good choise for no, so it is OK But for the error =E2=80=94 not found =E2=80=94 it is better to use -1 to c= omply with commonly used semantics. Best regards, Andrew Savchenko --Signature=_Sat__11_Apr_2020_13_46_55_+0300_QwsDNLunhZccokjK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE63ZIHsdeM+1XgNer9lNaM7oe5I0FAl6RoB8ACgkQ9lNaM7oe 5I0+9w/+KK6dewyP08rOMLJRZfTybNRt6LtRgauB0QXviWWId3xjAW7A2wa2MvS0 cOkY9Tjj3pPJ4MxXlQFETzip36xNGy2lmRnQx4HeD6Iye3XSCKpS9BBJhsGRNHx0 t5ibnfdbqp7lAR3QHNCgSZfgRy/3Qsfk/35WjYw7pnadlvKStnlp8a4h2YQW8vhI ywKi8Hg4OA5cImWpwp+qYf5awk9NJ4ejH2tagcInZhdu3ClcRARNUqeKQu5iNwrW gpyegt0elRXRAO7PmWn9UF78s0s1aN0KEU15grZqrge56TZOwaIGfbVCN8T/UKAe UGSTSxZeYnhqGTVtGstWZJLaXMg45R23Il4/p8rmuFBBSX5hZXvQJD40U9GZluAE 2ANbpXH9oOq6acGPOs1OfJeNi+qkDVHVB7EFXXOeNftdTIWJ7B7g+NgpKgShrsj6 L5Y8GoDRB8y4fBnMOLWOxhIm51gxLGaocVRpTU3TPHHI5lr3b+QLProVG3mUkumk JJjOg2Y/zeHqJnbCB08Luqoy1kdjYDC+S2TDoqWN74uB/x23UrOGYBRzUwmW8Wfg fVOVmwISTulVcIUSwJlG5D8qeFNiWpeW6gVl7HGttiGJvmwro7VxbAEEmUrkb4W+ h+FJ4kPpXnRtJb33CqSxU7NALtxIWd0q/p2akZrzs5CXdBXeuCQ= =fzNA -----END PGP SIGNATURE----- --Signature=_Sat__11_Apr_2020_13_46_55_+0300_QwsDNLunhZccokjK--