From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 From: Aleksei Nikiforov To: devel@lists.altlinux.org Date: Thu, 12 Dec 2019 12:57:19 +0300 Message-Id: <20191212095730.83787-11-darktemplar@altlinux.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191212095730.83787-1-darktemplar@altlinux.org> References: <20191211234857.GB17949@altlinux.org> <20191212095730.83787-1-darktemplar@altlinux.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Aleksei Nikiforov Subject: [devel] [PATCH for apt v2 10/21] Improve member variable initialization X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Dec 2019 09:58:11 -0000 Archived-At: List-Archive: List-Post: Found via cppcheck: (performance) Variable 'program' is assigned in constructor body. Consider performing initialization in initialization list. --- apt/methods/rsync.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apt/methods/rsync.cc b/apt/methods/rsync.cc index 64c9231..2b318fd 100644 --- a/apt/methods/rsync.cc +++ b/apt/methods/rsync.cc @@ -125,8 +125,8 @@ bool RsyncMethod::RsyncConn::initProxy() RsyncMethod::RsyncConnExec::RsyncConnExec(URI u, const string &_proxy, const string &prog) : RsyncConn(u,_proxy), ChildPid(-1), ChildFd(-1) + , program(prog.empty() ? RSYNC_PROGRAM : prog) { - program = prog.empty() ? RSYNC_PROGRAM : prog; } RsyncMethod::RsyncConnExec::~RsyncConnExec() -- 2.24.1