From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 12 Dec 2019 02:48:57 +0300 From: "Dmitry V. Levin" To: ALT Devel discussion list Message-ID: <20191211234857.GB17949@altlinux.org> References: <20191210152343.33867-1-darktemplar@altlinux.org> <20191210152343.33867-3-darktemplar@altlinux.org> <20191210224500.GC31774@altlinux.org> <1235fb34-3f69-3ac8-e357-bff0bf313fec@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1235fb34-3f69-3ac8-e357-bff0bf313fec@altlinux.org> Subject: Re: [devel] [PATCH for apt 02/38] Use correct types and type specifiers X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Dec 2019 23:48:57 -0000 Archived-At: List-Archive: List-Post: On Wed, Dec 11, 2019 at 10:56:36AM +0300, Aleksei Nikiforov wrote: > 11.12.2019 1:45, Dmitry V. Levin =D0=C9=DB=C5=D4: > > On Tue, Dec 10, 2019 at 06:23:07PM +0300, Aleksei Nikiforov wrote: > >> Found via cppcheck > >> --- > >> apt/apt-pkg/contrib/cdromutl.cc | 4 ++-- > >> apt/apt-pkg/contrib/strutl.cc | 8 ++++---- > >> apt/cmdline/acqprogress.cc | 4 ++-- > >> apt/methods/connect.cc | 4 ++-- > >> apt/methods/http.cc | 9 +++------ > >> apt/methods/http.h | 2 +- > >> 6 files changed, 14 insertions(+), 17 deletions(-) > >=20 > > It would be great if you included the cppcheck diagnostics as well, > > you can use the following commit as an example: > > https://gitlab.com/strace/strace/commit/2b64854e >=20 > So, should such blankets of text be added for each fixed line? Commit=20 > messages would become much bigger than commits themselves in that case=20 > for a lot of commits considering multiline messages and one-line fixes.= =20 > Is it really needed considering fixes are already grouped in commits by= =20 > type? Let's use common sense. If both the bug and the fix are obvious, there is no need to add anything. Otherwise, group all fixes by the kind of bug being fixed and include a single diagnostic message, e.g. the first diagnostic message of the series. --=20 ldv