On Tue, Dec 10, 2019 at 06:23:07PM +0300, Aleksei Nikiforov wrote:
> Found via cppcheck
> ---
>  apt/apt-pkg/contrib/cdromutl.cc | 4 ++--
>  apt/apt-pkg/contrib/strutl.cc   | 8 ++++----
>  apt/cmdline/acqprogress.cc      | 4 ++--
>  apt/methods/connect.cc          | 4 ++--
>  apt/methods/http.cc             | 9 +++------
>  apt/methods/http.h              | 2 +-
>  6 files changed, 14 insertions(+), 17 deletions(-)

It would be great if you included the cppcheck diagnostics as well,
you can use the following commit as an example:
https://gitlab.com/strace/strace/commit/2b64854e


-- 
ldv