From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Date: Mon, 9 Dec 2019 13:24:37 +0300
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Aleksei Nikiforov <darktemplar@altlinux.org>
Message-ID: <20191209102437.GA6554@altlinux.org>
References: <20191206131606.83061-1-darktemplar@altlinux.org>
 <20191208225047.GA30742@altlinux.org>
 <736ed459-fc98-d770-cfb3-8c4bf7477532@altlinux.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
In-Reply-To: <736ed459-fc98-d770-cfb3-8c4bf7477532@altlinux.org>
Cc: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH for apt 1/2] Add option for debugging
 DynamicMMap::Allocate
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Dec 2019 10:24:37 -0000
Archived-At: <http://lore.altlinux.org/devel/20191209102437.GA6554@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>


--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 09, 2019 at 09:58:55AM +0300, Aleksei Nikiforov wrote:
> 09.12.2019 1:50, Dmitry V. Levin =D0=C9=DB=C5=D4:
> > On Fri, Dec 06, 2019 at 04:16:05PM +0300, Aleksei Nikiforov wrote:
> >> ---
> >>   apt/apt-pkg/contrib/mmap.cc | 15 +++++++++++++++
> >>   apt/doc/apt.conf.5.sgml     |  2 +-
> >>   2 files changed, 16 insertions(+), 1 deletion(-)
> >=20
> > I suggest adding the name of the new option to the commit message
> > so it would be git-grep'able, for example:
> >=20
> > Add Debug::DynamicMMap::Allocate option
> >=20
> > Add a new option for debugging DynamicMMap::Allocate.
>=20
> But option name is already in commit message. See the email subject=20
> which is also a part of commit message. Why is it needed to duplicate it?

I don't see a duplication here, but anyway, this is just an example, and
"Add Debug::DynamicMMap::Allocate option" would be better than
"Add option for debugging DynamicMMap::Allocate".


--=20
ldv

--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJd7iDlAAoJEAVFT+BVnCUIBGUP/jvaCNoz/bMSncjQbVrnGPtC
pBmNr21c3eYWFfaOTi9g/tWRQ4zNnNXPz8OyNoQTgq7Ntg/tQiQsBiHw2U8HcbfA
ooq57ilK7DoWBcfSwUp87483aeC8/Wb1TUhR1OOdGPQEEBXz32LZPMB9ULB9s6G4
Z0eHVRHtY6N/bGrfWFHOhdGO129gaGFAbksFA2TambQDpk1xu7X9/VJuc45GHyGn
PaCt8st0yj1FU1Q60Att9AvPL4woQ4boviTbmzgRsM7Vf1wH1Xn9zJB9aiDlOY7J
E63EFJQa/2bqa9LCve3utEjP/JTN25Uq9a6ixmi9SlkFY7ZW02royoT8FQvkefoe
zLF9kwX3t7n8GdMZLU/vD5TcUWvPYT+FsJVhQXDxXbFlNcrKaR9/NX+TYy7fg9MV
JCC0OuX5IWak9yRWqEh8ZsbZkI5HDZD9XXfVycGdcvWVWGfUA7dKL/pFaBNQI9mN
bFVTne8rFhiyGdZPeRzNeEklQL3daxSAALLp971LSqD1fIbSsBvs3e5MBhGn7g+1
8Zs9ENQnAagZIduA9ztOs35/bDBIRcOU/rZxtfHFLH8h1nU0wLLa0QwlXfC+mXFA
wNgHf85Wms6QJL79ExeSZZrvQXhTrPuUk9bUU9m9hB/566RsdUBGblAa8qYChC5L
W6I4G4YgfcYHrAUMA5l5
=D5CO
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--