Re: [devel] [PATCH for apt 1/2] Add option for debugging DynamicMMap::Allocate

["Dmitry V. Levin" <ldv@altlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On Mon, Dec 09, 2019 at 09:58:55AM +0300, Aleksei Nikiforov wrote:
> 09.12.2019 1:50, Dmitry V. Levin пишет:
> > On Fri, Dec 06, 2019 at 04:16:05PM +0300, Aleksei Nikiforov wrote:
> >> ---
> >>   apt/apt-pkg/contrib/mmap.cc | 15 +++++++++++++++
> >>   apt/doc/apt.conf.5.sgml     |  2 +-
> >>   2 files changed, 16 insertions(+), 1 deletion(-)
> > 
> > I suggest adding the name of the new option to the commit message
> > so it would be git-grep'able, for example:
> > 
> > Add Debug::DynamicMMap::Allocate option
> > 
> > Add a new option for debugging DynamicMMap::Allocate.
> 
> But option name is already in commit message. See the email subject 
> which is also a part of commit message. Why is it needed to duplicate it?

I don't see a duplication here, but anyway, this is just an example, and
"Add Debug::DynamicMMap::Allocate option" would be better than
"Add option for debugging DynamicMMap::Allocate".


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]