From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 9 Dec 2019 01:56:20 +0300 From: "Dmitry V. Levin" To: ALT Devel discussion list Message-ID: <20191208225620.GB30742@altlinux.org> References: <20191206133647.dculnmwkd3yf2wjp@titan.localdomain> <20191206153655.86334-1-darktemplar@altlinux.org> <20191207175201.13ca3df6c2cfb01ef559b083@altlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Content-Disposition: inline In-Reply-To: <20191207175201.13ca3df6c2cfb01ef559b083@altlinux.org> Subject: Re: [devel] [PATCH for apt 2/2 v2] Fix pointer arithmetics X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Dec 2019 22:56:21 -0000 Archived-At: List-Archive: List-Post: --+g7M9IMkV8truYOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 07, 2019 at 05:52:01PM +0300, Andrey Savchenko wrote: > Hi all! >=20 > On Fri, 6 Dec 2019 18:36:55 +0300 Aleksei Nikiforov wrote: > > This change should fix pointer arithmetic issues for e2k. >=20 > This commit message is misleading. Pointer arithmetic is broken on > all architectures, but by pure chance in happens to work correctly > when gcc is used. On e2k the lcc compiler is used, so problem > manifests itself. But this doesn't change the fact that pointer > arithmetic was flawed on all architectures. Strictly speaking, it's not "broken", it's "UB", but I agree it is not specific to e2k. My original commit message for this change was the following: "Fix UB in pointer arithmetic Commit 6d5e6a689d07de8feef2cbecb24bc42d5994861b aka 0.5.15lorg2-alt70~9 among other changes introduced UB in pointer arithmetic by casting raw pointers to specific types." --=20 ldv --+g7M9IMkV8truYOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJd7X+UAAoJEAVFT+BVnCUIwIkQALdrQyEAv/INLau6P7wLzFVL pQf7d4TIlDxvWN0Va8B6bWTivUmUJ1hHCmB3sd5kH5qHDrsgKmihUZPtow2z4u7I k32GLj78vh2Qf+wF6xWfjn9mg4lXPIjff2tHBMKr6/h7wJ734hVjAbPRYGqOiq8J C+QytDpoRSRQEeLBeoJjA4z1+tkQVMBml5F0ZBSOpnKK0GLZoWfg4YDynPuMr9nr LB03afH5bgJ0i8lS6dixmzlkacPUOfYCdIKjAsHgHoGjE/mbjiKRvgbqSAC5xICd SMKQ6O3zH9bUv3rWLATABT3czHQNIQ/Z/dQY1he/0Xjp4QdD2P0xBjOdeq/LthGU kvP6SJrhTk9wTUyf7hPP9fCM7AnPi+e8KSs3XemeY60QTq/GdMwCJax0DSexEgRK gHGoR3O2aesxnDpSos/WZ3cEgSbmRps96VyV3RuL/HaLGcbO7+3Tu0iE/FIM91aP H+vQNIn3MkrcX69yk3lomgJVi9lyZOHqcsGKycYeJPcZg0yg6rWtNDUPCA0cTAzF BggwaHpwPpVKhun/egcVUaikUujk62rICrhza2DpJ7sncOd53sxjrUVtgi1WSHBI T4bxgveiW6k2e2sPKGtUQOL9XV5n+Hm416UbYVgjs+NQJy64dDL7bNVl7FiRsIPJ P/kHW41MBGt3FvkZjdfz =nCMO -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl--