Re: [devel] [SCM] packages/libv: heads/sisyphus

["Dmitry V. Levin" <ldv@altlinux.org>]

On Mon, Feb 18, 2019 at 08:02:22AM +0000, Andrey Bychkov wrote:
> Update of /people/mrdrew/packages/libv.git
> 
> Changes statistics since common ancestor `1.90-alt9.2-1-gda101da' follows:
>  libv.spec | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> Changelog since common ancestor `1.90-alt9.2-1-gda101da' follows:
> commit c973e0fda1d3a2192e6071d3d71efe2de2b4c170
> Author: Andrey Bychkov <mrdrew@altlinux.org>
> Date:   Thu Feb 14 10:34:12 2019 +0300
> 
>     1.90-alt10
>     
>     - no return statement in the non-void function fixed (according g++8)
> 
> Full diff since common ancestor `1.90-alt9.2-1-gda101da' follows:
> diff --git a/libv.spec b/libv.spec
> index d4c3561..24ca1c0 100644
> --- a/libv.spec
> +++ b/libv.spec
> @@ -3,18 +3,20 @@
>  
>  Name:		libv
>  Version:	1.90
> -Release:	alt9.2
> +Release:	alt10
>  Summary:	V is a free, multiple platform C++ graphical user interface framework
>  License:	LGPL
>  Group:		Development/C++
>  Source0:	%origname-%version.tar.bz2
>  Patch: libv-1.90-alt-make-3.82.patch
> +Patch1: %name-g++8.patch
>  URL:		http://www.objectcentral.com/
>  Packager:	Evgeny Sinelnikov <sin@altlinux.ru>
>  # Automatically added by buildreq on Thu Oct 25 2007
>  BuildRequires: gcc-c++ libXaw-devel libXmu-devel
>  
>  BuildRequires:	lesstif-devel, libXext-devel, libGLw-devel, libGLU-devel
> +ExclusiveArch: i586 x86_64

С этим изменением несколько проблем:
- к исправлению компиляции с gcc8-c++ подмешано нерелевантное добавление
  ExclusiveArch даже без упоминания в commit message;
- добавленный ExclusiveArch неправильный по сути, поскольку в libv нет
  ничего эксклюзивного;
- добавленный ExclusiveArch неправильный по форме, поскольку вместо i586
  следует использовать %ix86.

Просьба исправить.


-- 
ldv