Re: [devel] [SCM] packages/sisyphus_check: heads/sisyphus

["Dmitry V. Levin" <ldv@altlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

Hi,

On Mon, Dec 31, 2018 at 06:08:02PM +0000, Vladimir D. Seleznev wrote:
> Update of /people/vseleznv/packages/sisyphus_check.git
> 
> Changes statistics since `0.8.45-alt1_lcc' follows:
>  sisyphus_check/sisyphus_check.d/090-check-nvr | 4 ++--
>  sisyphus_check/sisyphus_check.spec            | 5 ++++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> Changelog since `0.8.45-alt1_lcc' follows:
> commit 4492627dbc313159208167883c58f79be3127377
> Author: Vladimir D. Seleznev <vseleznv@altlinux.org>
> Date:   Mon Dec 31 21:07:25 2018 +0300
> 
>     0.8.46-alt1
>     
>     - 090-check-nvr: make version and release check more strict
> 
> commit ad0b8da88affed1a222e21e4dde3ad443e6a5340
> Author: Vladimir D. Seleznev <vseleznv@altlinux.org>
> Date:   Mon Dec 31 21:04:02 2018 +0300
> 
>     090-check-nvr: make version and release check more strict
> 
> Full diff since `0.8.45-alt1_lcc' follows:
> diff --git a/sisyphus_check/sisyphus_check.d/090-check-nvr b/sisyphus_check/sisyphus_check.d/090-check-nvr
> index 6cb6f70..1c99af7 100644
> --- a/sisyphus_check/sisyphus_check.d/090-check-nvr
> +++ b/sisyphus_check/sisyphus_check.d/090-check-nvr
> @@ -16,12 +16,12 @@ check_nvr()
>  		rc=1
>  	fi
>  
> -	if printf %s "$rpm_version" |grep -qs '[%<=>]'; then
> +	if ! printf %s "$rpm_version" |grep -Eqs '^[[:alnum:]._+]+$'; then

У нас в Сизифе есть пакет ongres-scram-1.0.0~beta.2-alt1_5jpp8.src.rpm,
который эта проверка запретит.

Допустим, я догадываюсь, зачем нужна именно такая более строгая проверка,
но это нужно указать явно в commit message.

По технике, я бы предпочёл

	if printf %s "$rpm_version" |grep -qvx '[[:alnum:]][[:alnum:]._+]*'; then


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]