From: Alexey Tourbin <at@altlinux.ru>
To: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH 0/3] optimize rpmsetcmp()
Date: Sat, 4 Dec 2010 19:55:36 +0300
Message-ID: <20101204165535.GD15470@altlinux.org> (raw)
In-Reply-To: <20101204163048.GB12275@altlinux.org>
On Sat, Dec 04, 2010 at 07:30:49PM +0300, Dmitry V. Levin wrote:
> > I think I've made more amazing a change.
> > http://git.altlinux.org/gears/r/rpm.git?a=commitdiff;h=fc5b5a5f
>
> Have you tried to combine both optimizations?
What's the criteria of doing good enough?
I always thought that 'char bitv[]' is good enough.
Let's call it a reference implementation.
Kirill argued that changing bitv to bitmap could actually win both
some space and some time, as there's a possibility to handle 6 bits
at a time, and even Mshift bits at a time.
The problem is that, well, *bitv++ is replaced with something else.
The code will be no longer a reference implementation.
next prev parent reply other threads:[~2010-12-04 16:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 22:04 Kirill A. Shutsemov
2010-11-25 22:04 ` [devel] [PATCH 1/3] set.c: use packed bitmap for bit vector Kirill A. Shutsemov
2010-11-25 22:04 ` [devel] [PATCH 2/3] set.c: optimize putbits() Kirill A. Shutsemov
2010-11-25 22:04 ` [devel] [PATCH 3/3] set.c: optimize decode_golomb() Kirill A. Shutsemov
2010-11-26 8:35 ` [devel] [PATCH 0/3] optimize rpmsetcmp() Kirill A. Shutemov
2010-11-30 0:35 ` Dmitry V. Levin
2010-12-02 21:48 ` Dmitry V. Levin
2010-12-04 13:02 ` Alexey Tourbin
2010-12-04 16:30 ` Dmitry V. Levin
2010-12-04 16:55 ` Alexey Tourbin [this message]
2010-12-04 15:06 ` Alexey Tourbin
2010-12-04 16:29 ` Dmitry V. Levin
2010-12-04 16:42 ` Alexey Tourbin
2010-12-04 16:52 ` Dmitry V. Levin
2010-12-04 17:05 ` Alexey Tourbin
2010-12-04 17:52 ` Dmitry V. Levin
2010-12-04 21:28 ` Alexey Tourbin
2010-12-04 23:26 ` Dmitry V. Levin
2010-12-04 23:41 ` Alexey Tourbin
2010-12-05 0:03 ` Dmitry V. Levin
2010-12-05 0:21 ` Alexey Tourbin
2010-12-05 12:49 ` Michael Shigorin
2010-12-07 17:50 ` Dmitry V. Levin
2010-12-05 1:24 ` Alexey Tourbin
2010-12-05 11:18 ` Dmitry V. Levin
2010-12-05 12:39 ` Alexey Tourbin
2010-12-05 12:39 ` Michael Shigorin
2010-12-05 12:58 ` Alexey Tourbin
2010-12-05 15:27 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101204165535.GD15470@altlinux.org \
--to=at@altlinux.ru \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git