Re: [devel] [PATCH 8/8] set.c: update copyright notice

["Kirill A. Shutemov" <kirill@shutemov.name>]

On Tue, Nov 23, 2010 at 02:50:04PM +0300, Alexey Tourbin wrote:
> On Tue, Nov 23, 2010 at 08:42:25AM +0200, Kirill A. Shutemov wrote:
> > On Tue, Nov 23, 2010 at 04:38:53AM +0300, Alexey Tourbin wrote:
> > > On Tue, Nov 23, 2010 at 03:56:22AM +0300, Dmitry V. Levin wrote:
> > > > http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant
> > > GNU criteria are somewhat controversial.
> > Just stop discussing this. I've drop it, before 'git push'.
> 
> Anyway, I wonder why you ever THOUGHT you should fix my code.  As if it's
> something wrong with the code (which it isn't).  I think it passed many
> times a scrutiny (before it's been committed), and it looks GOOD.

No, it doesn't. Mixing code and declarations looks really ugly.
Other than that, probably, it's my style preferences. I like kernel code
style.

> 
> Also, I payed a lot of time to write COMMENTS and explain why exactly
> the code is supposed to work (the comments have been re-edited many times
> before I felt them enough convincing).

Comments are nice. Thanks.

> Is there really something wrong
> with the code, except for -std=gnu99 issues?

See my patchset about optimization of rpmsetcmp().

-- 
 Kirill A. Shutemov