From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 22 Nov 2010 08:40:46 +0300 From: Alexey Tourbin To: "Kirill A. Shutsemov" Message-ID: <20101122054046.GA22001@altlinux.org> References: <1289923002-14132-1-git-send-email-kirill@shutemov.name> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1289923002-14132-1-git-send-email-kirill@shutemov.name> Cc: "Alexey I. Froloff" , devel@lists.altlinux.org, Alexey Gladkov , "Dmitry V. Levin" Subject: Re: [devel] [PATCH 0/8] rpm: cleanup set.c and set.h X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 05:40:47 -0000 Archived-At: List-Archive: List-Post: On Tue, Nov 16, 2010 at 05:56:34PM +0200, Kirill A. Shutsemov wrote: > Let's try to make set-versions implementation more maintainable. > > Kirill A. Shutemov (8): > set.c, set.h: get rid of C++-style comments > set.c: get rid of nested functions I reckon most of these changes aren't necessary. This is my coding style, and yes, I use -std=gnu99 features. > set.c: fixup self-test functions declaration > set.c: slightly reformat code to increase its readability > set.c: do not mix declarations and code > set.c: use function-like syntax for sizeof. > set.c: cleanup self-tests > set.c: update copyright notice > > lib/set.c | 768 +++++++++++++++++++++++++++++++++++++------------------------ > lib/set.h | 12 +- > 2 files changed, 473 insertions(+), 307 deletions(-)