From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH 2/8] set.c: get rid of nested functions
Date: Wed, 17 Nov 2010 02:07:28 +0300
Message-ID: <20101116230727.GA26592@altlinux.org> (raw)
In-Reply-To: <20101116225453.GA14760@shutemov.name>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Wed, Nov 17, 2010 at 12:54:53AM +0200, Kirill A. Shutemov wrote:
> On Wed, Nov 17, 2010 at 01:14:58AM +0300, Dmitry V. Levin wrote:
> > On Tue, Nov 16, 2010 at 05:56:36PM +0200, Kirill A. Shutsemov wrote:
> > [...]
> > > +static inline
> > > +char *put_digit(char *base62, int c)
> > > - void put_digit(int c)
> > > - {
> >
> > Why shouldn't this and other functions remain returning void?
>
> We shift base62 to the next position and want caller to know about this.
>
> So we have two options:
>
> - return new position;
> - pass char ** as argument instead of char *.
>
> Do you prefere the last one?
Which one is more readable,
base62 = put_digit(base62, 61);
or
put_digit(&base62, 61);
?
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-11-16 23:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 15:56 [devel] [PATCH 0/8] rpm: cleanup set.c and set.h Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 1/8] set.c, set.h: get rid of C++-style comments Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 2/8] set.c: get rid of nested functions Kirill A. Shutsemov
2010-11-16 22:14 ` Dmitry V. Levin
2010-11-16 22:54 ` Kirill A. Shutemov
2010-11-16 23:07 ` Dmitry V. Levin [this message]
2010-11-16 23:10 ` Kirill A. Shutemov
2010-11-17 17:55 ` Dmitry V. Levin
2010-11-16 15:56 ` [devel] [PATCH 3/8] set.c: fixup self-test functions declaration Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 4/8] set.c: slightly reformat code to increase its readability Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 5/8] set.c: do not mix declarations and code Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 6/8] set.c: use function-like syntax for sizeof Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 7/8] set.c: cleanup self-tests Kirill A. Shutsemov
2010-11-16 15:56 ` [devel] [PATCH 8/8] set.c: update copyright notice Kirill A. Shutsemov
2010-11-22 5:49 ` Alexey Tourbin
2010-11-23 0:48 ` Alexey Tourbin
2010-11-23 0:56 ` Dmitry V. Levin
2010-11-23 1:38 ` Alexey Tourbin
2010-11-23 6:42 ` Kirill A. Shutemov
2010-11-23 11:50 ` Alexey Tourbin
2010-11-25 22:02 ` Kirill A. Shutemov
2010-11-26 18:03 ` Michael Shigorin
2010-11-17 6:59 ` [devel] [PATCH 0/8] rpm: cleanup set.c and set.h REAL
2010-11-22 5:40 ` Alexey Tourbin
2010-11-22 7:14 ` Kirill A. Shutemov
2010-11-22 7:38 ` Alexey Tourbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116230727.GA26592@altlinux.org \
--to=ldv@altlinux.org \
--cc=devel@lists.altlinux.org \
--cc=kirill@shutemov.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git