From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on sa.int.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.2.5 Date: Mon, 20 Jul 2009 15:42:11 +0400 From: Sergey Vlasov To: devel@lists.altlinux.org Message-ID: <20090720114211.GA16786@newmaster.mivlgu.local> Mail-Followup-To: devel@lists.altlinux.org References: <20090720095659.0CACB151C15F@granary.armor.altlinux.org> <20090720100503.GI28191@osdn.org.ua> <20090720105828.GA16178@osdn.org.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline In-Reply-To: <20090720105828.GA16178@osdn.org.ua> Subject: Re: [devel] mtools-4.0.10-alt1: Sisyphus/i586 test rebuild failed X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2009 11:42:29 -0000 Archived-At: List-Archive: List-Post: --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 20, 2009 at 01:58:28PM +0300, Michael Shigorin wrote: > On Mon, Jul 20, 2009 at 01:05:03PM +0300, I wrote: > > On Mon, Jul 20, 2009 at 01:56:59PM +0400, QA Team Robot wrote: > > > Package: mtools-4.0.10-alt1 > > > Status: Sisyphus/i586 test rebuild failed > > =F0=D2=C9=CD=D5 =D0=CF=CD=CF=DD=D8 =D7 =C9=D3=D0=D2=C1=D7=CC=C5=CE=C9= =C9 mtools (=C2=C5=D2=D5=D3=D8 =CF=D4=CE=C5=D3=D4=C9 =D0=C1=D4=DE =C1=D0=D3= =D4=D2=C9=CD=D5), > > =C9=CE=C1=DE=C5 =D0=C1=CB=C5=D4 =C5=D3=D4=C5=D3=D4=D7=C5=CE=CE=D9=CD = =CF=C2=D2=C1=DA=CF=CD =CF=D3=D4=C1=CE=C5=D4=D3=D1 =C2=C5=DA =CD=C1=CA=CE=D4= =C5=CA=CE=C5=D2=C1. >=20 > =EC=C1=C4=CE=CF, =CB=CF=D3=D4=D9=CC=D8 =D1 =D4=D5=C4=C1 =D0=CF=CC=CF=D6= =C9=CC. =E1 =D4=C5=D0=C5=D2=D8 =CF=C2=DF=D1=D3=CE=C9=D4=C5 =CD=CE=C5 =CB= =D4=CF-=CE=C9=D4=D8 > =D0=CF=CE=C9=CD=C1=C0=DD=C9=CA, =D0=CF=DE=C5=CD=D5 =C9=D3=C8=CF=C4=CE=D9= =CA =D0=C1=D4=DE-=D4=CF =CE=C5 =D0=D2=CF=CB=CF=CE=C1=CC? =EF=CE =CC=CF=C7= =C9=DE=CE=C5=CA. >=20 > > > In file included from /usr/include/string.h:658, > > > from sysincludes.h:264, > > > from mlabel.c:22: > > > In function 'strcpy', > > > inlined from 'label_name' at mlabel.c:38: > > > /usr/include/bits/string3.h:106: error: call to __builtin___strcpy_ch= k will always overflow destination buffer > > > make: Leaving directory `/usr/src/RPM/BUILD/mtools-4.0.10' > > > make: *** [mlabel.o] Error 1 > >=20 >=20 > --=20 > ---- WBR, Michael Shigorin > ------ Linux.Kiev http://www.linux.kiev.ua/ > diff -Naur mtools-4.0.10-orig/file_name.h mtools-4.0.10/file_name.h > --- mtools-4.0.10-orig/file_name.h 2009-02-19 22:41:14 +0200 > +++ mtools-4.0.10/file_name.h 2009-07-20 13:42:26 +0300 > @@ -26,8 +26,8 @@ > * MYFILE TXT > */ > struct dos_name_t { > - char base[8]; > - char ext[3]; > + char base[9]; > + char ext[4]; =F4=C1=CB=CF=CA "=CB=CF=D3=D4=D9=CC=D8" =D7=D3=A3 =D3=CC=CF=CD=C1=C5=D4 - = =DC=D4=C1 =D3=D4=D2=D5=CB=D4=D5=D2=C1 =C4=CF=CC=D6=CE=C1 =D3=CF=CF=D4=D7=C5= =D4=D3=D4=D7=CF=D7=C1=D4=D8 =C6=CF=D2=CD=C1=D4=D5 =C8=D2=C1=CE=C5=CE=C9=D1 =C9=CD=C5=CE=C9 =C6=C1=CA=CC= =C1 =D7 =C6=C1=CA=CC=CF=D7=CF=CA =D3=C9=D3=D4=C5=CD=C5 FAT. > char sentinel; > }; > =20 > diff -Naur mtools-4.0.10-orig/mlabel.c mtools-4.0.10/mlabel.c > --- mtools-4.0.10-orig/mlabel.c 2009-03-03 08:10:11 +0200 > +++ mtools-4.0.10/mlabel.c 2009-07-20 13:34:02 +0300 > @@ -35,7 +35,8 @@ > int have_lower, have_upper; > wchar_t wbuffer[12]; > =20 > - strcpy(ans->base," "); > + strcpy(ans->base," "); > + strcpy(ans->ext," "); > len =3D native_to_wchar(filename, wbuffer, 11, 0, 0); > if(len > 11){ > *mangled =3D 1; > diff -Naur mtools-4.0.10-orig/mlabel.c mtools-4.0.10/mlabel.c > --- mtools-4.0.10-orig/mlabel.c 2009-03-03 08:10:11 +0200 > +++ mtools-4.0.10/mlabel.c 2009-07-20 13:34:02 +0300 > @@ -35,7 +35,8 @@ > int have_lower, have_upper; > wchar_t wbuffer[12]; > =20 > - strcpy(ans->base," "); > + strcpy(ans->base," "); > + strcpy(ans->ext," "); =FA=C1=D7=C5=D2=DB=C1=C0=DD=C9=CA \0 =D7=D3=A3 =D2=C1=D7=CE=CF =CE=C5 =CC= =C5=DA=C5=D4 =D7 =C2=D5=C6=C5=D2. =ED=CF=D6=CE=CF =D0=CF=D0=D2=CF=C2=CF=D7=C1=D4=D8 =D4=C1=CB (=C4=CC=D1 memc= py =D0=D2=CF=D7=C5=D2=CB=C9 =CE=C5 =D7=D9=D0=CF=CC=CE=D1=C0=D4=D3=D1): --- mtools-4.0.10/mlabel.c.orig 2009-07-20 15:36:44 +0400 +++ mtools-4.0.10/mlabel.c 2009-07-20 15:36:48 +0400 @@ -35,7 +35,7 @@ void label_name(doscp_t *cp, const char=20 int have_lower, have_upper; wchar_t wbuffer[12]; =20 - strcpy(ans->base," "); + memcpy(ans->base, " ", 12); len =3D native_to_wchar(filename, wbuffer, 11, 0, 0); if(len > 11){ *mangled =3D 1; =E9=CC=C9 =C2=CF=CC=C5=C5 =D0=CF=CE=D1=D4=CE=D9=CD =CF=C2=D2=C1=DA=CF=CD: --- mtools-4.0.10/mlabel.c.orig 2009-07-20 15:36:44 +0400 +++ mtools-4.0.10/mlabel.c 2009-07-20 15:40:28 +0400 @@ -35,7 +35,10 @@ void label_name(doscp_t *cp, const char=20 int have_lower, have_upper; wchar_t wbuffer[12]; =20 - strcpy(ans->base," "); + memset(ans->base, ' ', sizeof ans->base); + memset(ans->ext, ' ', sizeof ans->ext); + ans->sentinel =3D '\0'; + len =3D native_to_wchar(filename, wbuffer, 11, 0, 0); if(len > 11){ *mangled =3D 1; --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFKZFgTW82GfkQfsqIRAiViAJ96lDxew7wDqCEmq46zvXH17AXkfwCfW9o5 RHE6C4p9Z5h1y5NYNjiXS3g= =gBbw -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD--