From: Michael Shigorin <mike@osdn.org.ua> To: devel@lists.altlinux.org Subject: Re: [devel] mtools-4.0.10-alt1: Sisyphus/i586 test rebuild failed Date: Mon, 20 Jul 2009 13:58:28 +0300 Message-ID: <20090720105828.GA16178@osdn.org.ua> (raw) In-Reply-To: <20090720100503.GI28191@osdn.org.ua> [-- Attachment #1: Type: text/plain, Size: 978 bytes --] On Mon, Jul 20, 2009 at 01:05:03PM +0300, I wrote: > On Mon, Jul 20, 2009 at 01:56:59PM +0400, QA Team Robot wrote: > > Package: mtools-4.0.10-alt1 > > Status: Sisyphus/i586 test rebuild failed > Приму помощь в исправлении mtools (берусь отнести патч апстриму), > иначе пакет естественным образом останется без майнтейнера. Ладно, костыль я туда положил. А теперь объясните мне кто-нить понимающий, почему исходный патч-то не проконал? Он логичней. > > In file included from /usr/include/string.h:658, > > from sysincludes.h:264, > > from mlabel.c:22: > > In function 'strcpy', > > inlined from 'label_name' at mlabel.c:38: > > /usr/include/bits/string3.h:106: error: call to __builtin___strcpy_chk will always overflow destination buffer > > make: Leaving directory `/usr/src/RPM/BUILD/mtools-4.0.10' > > make: *** [mlabel.o] Error 1 > -- ---- WBR, Michael Shigorin <mike@altlinux.ru> ------ Linux.Kiev http://www.linux.kiev.ua/ [-- Attachment #2: mtools-4.0.10-alt-buffer.patch --] [-- Type: text/plain, Size: 761 bytes --] diff -Naur mtools-4.0.10-orig/file_name.h mtools-4.0.10/file_name.h --- mtools-4.0.10-orig/file_name.h 2009-02-19 22:41:14 +0200 +++ mtools-4.0.10/file_name.h 2009-07-20 13:42:26 +0300 @@ -26,8 +26,8 @@ * MYFILE TXT */ struct dos_name_t { - char base[8]; - char ext[3]; + char base[9]; + char ext[4]; char sentinel; }; diff -Naur mtools-4.0.10-orig/mlabel.c mtools-4.0.10/mlabel.c --- mtools-4.0.10-orig/mlabel.c 2009-03-03 08:10:11 +0200 +++ mtools-4.0.10/mlabel.c 2009-07-20 13:34:02 +0300 @@ -35,7 +35,8 @@ int have_lower, have_upper; wchar_t wbuffer[12]; - strcpy(ans->base," "); + strcpy(ans->base," "); + strcpy(ans->ext," "); len = native_to_wchar(filename, wbuffer, 11, 0, 0); if(len > 11){ *mangled = 1; [-- Attachment #3: mtools-4.0.10-alt-buffer.patch.orig --] [-- Type: text/plain, Size: 426 bytes --] diff -Naur mtools-4.0.10-orig/mlabel.c mtools-4.0.10/mlabel.c --- mtools-4.0.10-orig/mlabel.c 2009-03-03 08:10:11 +0200 +++ mtools-4.0.10/mlabel.c 2009-07-20 13:34:02 +0300 @@ -35,7 +35,8 @@ int have_lower, have_upper; wchar_t wbuffer[12]; - strcpy(ans->base," "); + strcpy(ans->base," "); + strcpy(ans->ext," "); len = native_to_wchar(filename, wbuffer, 11, 0, 0); if(len > 11){ *mangled = 1;
next prev parent reply other threads:[~2009-07-20 10:58 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-20 10:05 ` Michael Shigorin 2009-07-20 10:58 ` Michael Shigorin [this message] 2009-07-20 11:42 ` Sergey Vlasov 2009-07-20 12:14 ` Michael Shigorin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090720105828.GA16178@osdn.org.ua \ --to=mike@osdn.org.ua \ --cc=devel@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Team development discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \ devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru public-inbox-index devel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git