From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <victor@gu.net>
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on sa.int.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.3
Date: Wed, 20 Feb 2008 15:14:30 +0200
From: Victor Forsyuk <force@altlinux.org>
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Message-ID: <20080220131430.GA7413@mail.gu.net>
References: <20080219234137.GA27844@granary.armor.altlinux.org>
	<20080219235603.GA28046@wo.int.altlinux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080219235603.GA28046@wo.int.altlinux.org>
User-Agent: Mutt/1.4.1i
Sender: Victor Forsyuk <victor@gu.net>
Subject: Re: [devel] bonnie-1.4-alt3 (PAGE_MASK)
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2008 13:14:34 -0000
Archived-At: <http://lore.altlinux.org/devel/20080220131430.GA7413@mail.gu.net/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Wed, Feb 20, 2008 at 02:56:03AM +0300, Dmitry V. Levin wrote:
> Hi,
> 
> On Wed, Feb 20, 2008 at 02:41:37AM +0300, QA Team Robot wrote:
> > bonnie - Unix filesystem performance benchmark
> > * Mon Feb 18 2008 Victor Forsyuk <force@altlinux> 1.4-alt3
> > - Include sys/user.h for PAGE_MASK definition due to unexported
> >   asm/page.h in glibc-kernheaders-2.6.18-alt4.
> 
> Не надо использовать sys/user.h, если вы не gdb.

Rationale?
 
> $ info libc 'Query Memory Parameters'

Это всё понятно. Проблема в том, что PAGE_MASK определяется по разному в BSD
и Linux. В BSD это "(PAGE_SIZE-1)", в Линуксе - "~(PAGE_SIZE-1)".

Определять PAGE_MASK в исходнике - это убить переносимость. Следовательно,
нужно брать из хедеров системы.

Где я неправ?