From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kirill@altlinux.org>
Date: Tue, 19 Feb 2008 03:40:41 +0300
From: Kirill Maslinsky <kirill@altlinux.org>
To: ALT Linux Team development discussions <devel@lists.altlinux.org>
Message-ID: <20080219004041.GE25921@imap.altlinux.org>
Mail-Followup-To: ALT Linux Team development discussions
	<devel@lists.altlinux.org>
References: <20080218173649.02D5B151C8AC@granary.armor.altlinux.org>
	<20080219000628.GA27741@wo.int.altlinux.org>
	<20080219001811.GD25921@imap.altlinux.org>
	<200802190223.41135.ledest@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <200802190223.41135.ledest@gmail.com>
User-Agent: Mutt/1.4.2.3i
Organization: ALT Docs Team
Subject: Re: [devel] asm/page.h
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
	<mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Feb 2008 00:40:41 -0000
Archived-At: <http://lore.altlinux.org/devel/20080219004041.GE25921@imap.altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Tue, Feb 19, 2008 at 02:23:41AM +0200, Led wrote:
> Tuesday, 19 February 2008 02:18:11 Kirill Maslinsky написав:

[...]

> > -               if (size > PAGE_SIZE)
> > -                       bulk.len = PAGE_SIZE;
> > +               if (size > sysconf(_SC_PAGESIZE))
> > +                       bulk.len = sysconf(_SC_PAGESIZE);

> Зачем дважды вызывать? ИМХО лучше завести переменную page_size.

Логично. Вот так будет корректно?

--- a/eciadsl-usermode/pusb-linux.c
+++ b/eciadsl-usermode/pusb-linux.c
@@ -29,7 +29,6 @@
 #include <string.h>
 
 #include "pusb-linux.h"
-#include <asm/page.h>
 
 #include "pusb.h"
 
@@ -431,6 +430,7 @@ inline int pusb_endpoint_rw(int fd, int ep, unsigned char* buf, int size, int ti
        static struct usbdevfs_bulktransfer bulk;
        static int ret;
        int received = 0;
+       int page_size = sysconf(_SC_PAGESIZE);
 
        do
        {
@@ -438,8 +438,8 @@ inline int pusb_endpoint_rw(int fd, int ep, unsigned char* buf, int size, int ti
 
                bulk.len = size;
 
-               if (size > PAGE_SIZE)
-                       bulk.len = PAGE_SIZE;
+               if (size > page_size)
+                       bulk.len = page_size;
 
Вы меня простите за тупые вопросы, я просто этого языка (C) вообще не знаю, 
опасаюсь напортачить. 


-- 
Kirill Maslinsky
ALT Linux Team