From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Nov 2007 17:33:27 +0300 From: "Dmitry V. Levin" To: ALT Linux Team development discussions Message-ID: <20071127143327.GK11953@basalt.office.altlinux.org> Mail-Followup-To: ALT Linux Team development discussions References: <20071125120814.GA22522@basalt.office.altlinux.org> <20071125195520.GS28492@osdn.org.ua> <20071125211632.GC30421@basalt.office.altlinux.org> <679044850711270211x1cb7816mb893f4021137e2f@mail.gmail.com> <20071127141036.GH11953@basalt.office.altlinux.org> <679044850711270625o765fa019m9006d13dba5304f7@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ah40dssYA/cDqAW1" Content-Disposition: inline In-Reply-To: <679044850711270625o765fa019m9006d13dba5304f7@mail.gmail.com> X-fingerprint: FE4C 93AB E19A 2E4C CB5D 3E4E 7CAB E6AC 9E35 361E Subject: Re: [devel] IA: destination buffer overflow X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2007 14:33:28 -0000 Archived-At: List-Archive: List-Post: --Ah40dssYA/cDqAW1 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2007 at 05:25:22PM +0300, Damir Shayhutdinov wrote: > > =FC=D4=CF=D4 =CB=D5=D3=CF=CB =CB=CF=C4=C1 =CD=CF=D6=CE=CF =D5=D0=D2=CF= =D3=D4=C9=D4=D8 =C4=CF > > > > extern struct { char a; } from[1], to[1]; > > void copy(int n) > > { > > if (n !=3D 0) > > memcpy(&to[1], &from[0], sizeof(to[1])); > > } > > > > =EB=CF=CD=D0=C9=CC=D1=D4=CF=D2 =CF=C4=CE=CF=DA=CE=C1=DE=CE=CF =C7=CF=D7= =CF=D2=C9=D4: will always overflow destination buffer > > =EF=CE =D0=D2=C1=D7, =C5=D3=CC=C9 =D3=CC=D5=DE=C9=D4=D3=D1 n !=3D 0, = =D4=CF =C2=D5=C4=C5=D4 =D7=D9=D0=CF=CC=CE=C5=CE =CB=CF=C4, =CB=CF=D4=CF=D2= =D9=CA =D7=D3=C5=C7=C4=C1 > > =D0=D2=C9=D7=CF=C4=C9=D4 =CB overflow. =E5=D3=CC=C9 n =D7=D3=C5=C7=C4= =C1 0, =D4=CF =DC=D4=CF=D4 =D7=D2=C5=C4=CF=CE=CF=D3=CE=D9=CA =CB=CF=C4 =CE= =C5 > > =D7=D9=D0=CF=CC=CE=C9=D4=D3=D1 =CE=C9=CB=CF=C7=C4=C1, =C9 =C5=C7=CF =CD= =CF=D6=CE=CF =D5=C2=D2=C1=D4=D8 =D7=CD=C5=D3=D4=C5 =D3 =D0=D2=CF=D7=C5=D2= =CB=CF=CA n !=3D 0. > > > > =F7 =D7=C1=DB=C5=CD =D3=CC=D5=DE=C1=C5 =D0=D2=C5=C4=D5=D0=D2=C5=D6=C4= =C5=CE=C9=C5 =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2=C1 =D0=D2=CF=D0=C1=C4=A3=D4, = =CB=C1=CB =D4=CF=CC=D8=CB=CF MAX_PLAYERS > > =D3=D4=C1=CE=C5=D4 =C2=CF=CC=D8=DB=C5 1. > =E4=C1, =CE=CF =D0=D2=CF=C2=CC=C5=CD=C1 =D7 =D4=CF=CD =DE=D4=CF =DC=D4=CF= =D3=C9=CD=D7=CF=CC =D0=D2=C5=D0=D2=CF=C3=C5=D3=D3=CF=D2=C1, =C9 =CE=C1=D3= =CB=CF=CC=D8=CB=CF =D1 > =D0=CF=CE=C9=CD=C1=C0, =C1=D7=D4=CF=D2=D9 =D7 =C2=D5=C4=D5=DD=C5=CD =D0= =CF=CD=C5=CE=D1=C0=D4 =C5=C7=CF =DA=CE=C1=DE=C5=CE=C9=C5. =F3=C1=CD =D0=CF = =D3=C5=C2=C5 =CB=CF=C4 > =D7=D0=CF=CC=CE=C5 =D0=D2=C1=D7=CF=CD=CF=DE=C5=CE, =C5=D3=CC=C9 =C2=D9 = =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2 =CE=C5 =DA=CE=C1=CC, =DE=D4=CF MAX_PLAYERS = =3D 1. > =E1=D7=D4=CF=D2=D9 =D0=C9=D3=C1=CC=C9 =CB=CF=C4 =D4=C1=CB, =DE=D4=CF=C2= =D9 =CF=CE =CE=C5 =DA=C1=D7=C9=D3=C5=CC =CF=D4 =DA=CE=C1=DE=C5=CE=C9=D1 MAX= _PLAYERS. >=20 > =E1 =D7 =C9=D4=CF=C7=C5 =D0=CF=CC=D5=DE=C1=C5=D4=D3=D1 =DE=D4=CF =CB=CF= =CD=D0=C9=CC=D1=D4=CF=D2 =C9=DA-=DA=C1 =CF=D0=D4=C9=CD=C9=DA=C1=C3=C9=C9 = =DA=C1=D0=C1=CE=C9=CB=CF=D7=C1=CC =CE=C1 > =D2=CF=D7=CE=CF=CD =CD=C5=D3=D4=C5. =E6=CF=D2=CD=C1=CC=D8=CE=CF =CF=CE = =CB=CF=CE=C5=DE=CE=CF =D0=D2=C1=D7, =C1 =D0=D2=C1=CB=D4=C9=DE=C5=D3=CB=C9 -= =CE=C5=D4. =FC=D4=CF =D1 =C9 > =D3=DE=C9=D4=C1=C0 =CE=C5=D3=CF=D7=C5=D2=DB=C5=CE=D3=D4=D7=CF=CD =D0=D2= =CF=D7=C5=D2=CB=C9. =EF=CE =C9 =D0=D2=C1=CB=D4=C9=DE=C5=D3=CB=C9 =D0=D2=C1=D7: =D0=CF=D3=CB=CF= =CC=D8=CB=D5 =D5 =C6=D5=CE=CB=C3=C9=C9 CopyMeToNetworkMe() =C7=CC=CF=C2=C1= =CC=D8=CE=C1=D1 =CC=C9=CE=CB=CF=D7=CB=C1, =CE=C5=D4 =CE=C9=CB=C1=CB=C9=C8 =C7=C1=D2=C1=CE= =D4=C9=CA =D4=CF=C7=CF =DE=D4=CF =CF=CE=C1 =C2=D5=C4=C5=D4 =D7=D9=DA=D7=C1= =CE=C1 =D0=D2=C1=D7=C9=CC=D8=CE=CF. > =E9=DA-=DA=C1 =CE=C5=C7=CF =CB =CB=C1=D6=C4=CF=CD=D5 =D0=D2=C5=C4=D5=D0= =D2=C5=D6=C4=C5=CE=C9=C0 =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2=C1 =D0=D2=C9=C8=CF= =C4=C9=D4=D3=D1 =D0=CF=C4=C8=CF=C4=C9=D4=D8 > =C9=CE=C4=C9=D7=C9=C4=D5=C1=CC=D8=CE=CF. =EF=C2=C9=C4=CE=CF =D4=C1=CB=D6= =C5 =D4=CF, =DE=D4=CF =C1=D0=D3=D4=D2=C9=CD=D5 =CE=C5=CF=C2=C8=CF=C4=C9=CD= =CF=D3=D4=D8 guard-=C1 > =C2=D5=C4=C5=D4 =D3=CC=CF=D6=CE=CF =CF=C2=DF=D1=D3=CE=C9=D4=D8. =ED=CF=A3 =CF=C2=DF=D1=D3=CE=C5=CE=C9=C5 =CD=CF=D6=C5=D4 =CF=CB=C1=DA=C1=D4= =D8=D3=D1 =CE=C5=C4=CF=D3=D4=C1=D4=CF=DE=CE=CF =C4=CF=D3=D4=D5=D0=CE=CF? > > =E4=CF=C2=C1=D7=C5=CE=CE=C1=D1 =D7=C1=CD=C9 =D0=D2=CF=D7=C5=D2=CB=C1 --= =DC=D4=CF =CE=C5 =CC=C9=DB=CE=C9=CA guard, =C2=CC=C1=C7=CF=C4=C1=D2=D1 =CE= =C5=CA > > =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2 =D7=D9=CB=C9=CE=D5=CC =D7=C5=D3=D8 =C3= =C9=CB=CC. >=20 > =EE=D5 =C4=C1, =C5=D3=CC=C9 =CF=D3=CE=CF=D7=D9=D7=C1=D4=D8=D3=D1 =CE=C1 = =D0=D2=C5=C4=D0=CF=CC=CF=D6=C5=CE=C9=C9 =DE=D4=CF MAX_PLAYERS =C2=D5=C4=C5= =D4 =D7=D3=C5=C7=C4=C1 =D2=C1=D7=CE=CF 1. =E1=CC=D8=D4=C5=D2=CE=C1=D4=C9=D7=CE=D9=CA =D7=C1=D2=C9=C1=CE=D4 -- =DA=C1= =D7=C5=D2=CE=D5=D4=D8 =DC=D4=CF=D4 =DA=CC=CF=D0=CF=CC=D5=DE=CE=D9=CA =C3=C9= =CB=CC =D7 #if MAX_PLAYERS > 1. --=20 ldv --Ah40dssYA/cDqAW1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFHTCq3fKvmrJ41Nh4RAjPrAKCcosmtCcXcYtj/o1SJF0zBtyzn3ACeLgVP 9gxmbs6xKWd8NXL1vFeKoHI= =Q1xD -----END PGP SIGNATURE----- --Ah40dssYA/cDqAW1--