From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Nov 2007 17:10:36 +0300 From: "Dmitry V. Levin" To: ALT Devel discussion list Message-ID: <20071127141036.GH11953@basalt.office.altlinux.org> Mail-Followup-To: ALT Devel discussion list References: <20071125120814.GA22522@basalt.office.altlinux.org> <20071125195520.GS28492@osdn.org.ua> <20071125211632.GC30421@basalt.office.altlinux.org> <679044850711270211x1cb7816mb893f4021137e2f@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline In-Reply-To: <679044850711270211x1cb7816mb893f4021137e2f@mail.gmail.com> X-fingerprint: FE4C 93AB E19A 2E4C CB5D 3E4E 7CAB E6AC 9E35 361E Subject: Re: [devel] IA: destination buffer overflow X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2007 14:10:37 -0000 Archived-At: List-Archive: List-Post: --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2007 at 01:11:10PM +0300, Damir Shayhutdinov wrote: [...] > =F1 =D7=DE=C5=D2=C1 =CE=C1=C2=CC=C0=C4=C1=CC =D0=D2=C9=CD=C5=D2 =CC=CF=D6= =CE=CF=C7=CF =D3=D2=C1=C2=C1=D4=D9=D7=C1=CE=C9=D1, =CB=CF=D4=CF=D2=CF=C5 = =D0=D2=C9=DB=CC=CF=D3=D8 > =DA=C1=CC=C5=DE=C9=D4=D8 =D7=CF=D4 =D4=C1=CB=C9=CD =D7=CF=D4 =D0=C1=D4=DE= =C5=CD: >=20 > http://git.altlinux.org/people/damir/packages/?p=3Dfreedroidrpg.git;a=3Db= lob;f=3Dfreedroidrpg-0.10.3-alt-fix-buffer-overflow.patch;h=3D3cf47e900b136= 8bdbfde78c5722c8dc2c9b7b123;hb=3D778a38a4dd43d61abd87e07946937c9de6a8a8a9 >=20 > =EC=CF=D6=CE=CF=C5 =D3=D2=C1=C2=C1=D4=D9=D7=C1=CE=C9=C5 =C2=D9=CC=CF =D7 = freedroidrpg/src/network.c:654 >=20 > =E6=CF=D2=CD=D5=CC=C9=D2=CF=D7=CB=C1 =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2=C1 = =C2=D9=CC=C1 =CF=C4=CE=CF=DA=CE=C1=DE=CE=C1 - always overflow. =EE=C1 =D3= =C1=CD=CF=CD > =C4=C5=CC=C5, =C4=CF =D4=C5=C8 =D0=CF=D2 =D0=CF=CB=C1 0 <=3D PlayerNum < = MAX_PLAYERS (=C1 =DC=D4=CF =C9=CD=C5=CE=CE=CF =D4=C1=CB > =D0=D2=C9 =D7=D3=C5=C8 =D7=D9=DA=CF=D7=C1=C8 =DC=D4=CF=CA =C6=D5=CE=CB=C3= =C9=C9), =CE=C9=CB=C1=CB=CF=C7=CF overflow =CE=C5 =C2=D5=C4=C5=D4. >=20 > =F0=D2=C9=DB=CC=CF=D3=D8 =C4=CF=C2=C1=D7=CC=D1=D4=D8 =CC=C9=DB=CE=C9=CA g= uard, =DE=D4=CF=C2=D9 =D5=CD=C9=CC=CF=D3=D4=C9=D7=C9=D4=D8 =CB=CF=CD=D0=C9= =CC=D1=D4=CF=D2. =FC=D4=CF=D4 =CB=D5=D3=CF=CB =CB=CF=C4=C1 =CD=CF=D6=CE=CF =D5=D0=D2=CF=D3= =D4=C9=D4=D8 =C4=CF extern struct { char a; } from[1], to[1]; void copy(int n) { if (n !=3D 0) memcpy(&to[1], &from[0], sizeof(to[1])); } =EB=CF=CD=D0=C9=CC=D1=D4=CF=D2 =CF=C4=CE=CF=DA=CE=C1=DE=CE=CF =C7=CF=D7=CF= =D2=C9=D4: will always overflow destination buffer =EF=CE =D0=D2=C1=D7, =C5=D3=CC=C9 =D3=CC=D5=DE=C9=D4=D3=D1 n !=3D 0, =D4=CF= =C2=D5=C4=C5=D4 =D7=D9=D0=CF=CC=CE=C5=CE =CB=CF=C4, =CB=CF=D4=CF=D2=D9=CA = =D7=D3=C5=C7=C4=C1 =D0=D2=C9=D7=CF=C4=C9=D4 =CB overflow. =E5=D3=CC=C9 n =D7=D3=C5=C7=C4=C1 0= , =D4=CF =DC=D4=CF=D4 =D7=D2=C5=C4=CF=CE=CF=D3=CE=D9=CA =CB=CF=C4 =CE=C5 =D7=D9=D0=CF=CC=CE=C9=D4=D3=D1 =CE=C9=CB=CF=C7=C4=C1, =C9 =C5=C7=CF =CD=CF= =D6=CE=CF =D5=C2=D2=C1=D4=D8 =D7=CD=C5=D3=D4=C5 =D3 =D0=D2=CF=D7=C5=D2=CB= =CF=CA n !=3D 0. =F7 =D7=C1=DB=C5=CD =D3=CC=D5=DE=C1=C5 =D0=D2=C5=C4=D5=D0=D2=C5=D6=C4=C5=CE= =C9=C5 =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2=C1 =D0=D2=CF=D0=C1=C4=A3=D4, =CB=C1= =CB =D4=CF=CC=D8=CB=CF MAX_PLAYERS =D3=D4=C1=CE=C5=D4 =C2=CF=CC=D8=DB=C5 1. =E4=CF=C2=C1=D7=C5=CE=CE=C1=D1 =D7=C1=CD=C9 =D0=D2=CF=D7=C5=D2=CB=C1 -- =DC= =D4=CF =CE=C5 =CC=C9=DB=CE=C9=CA guard, =C2=CC=C1=C7=CF=C4=C1=D2=D1 =CE=C5= =CA =CB=CF=CD=D0=C9=CC=D1=D4=CF=D2 =D7=D9=CB=C9=CE=D5=CC =D7=C5=D3=D8 =C3=C9=CB= =CC. --=20 ldv --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFHTCVcfKvmrJ41Nh4RAo8bAJ0XLfM5c7QXmM6TaVzGctmKZe74VwCbB6CB tefWhBiR9JyGyuwPC/PuUJI= =prn1 -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE--