From: Alexey Tourbin <at@altlinux.ru>
To: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [git update] packages/rpm: heads/master
Date: Tue, 20 Nov 2007 14:18:01 +0300
Message-ID: <20071120111801.GI23589@solemn.turbinal> (raw)
In-Reply-To: <75e139a00711200312p22759de9m1c48c39006a361ce@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Tue, Nov 20, 2007 at 05:12:59PM +0600, Slava Semushin wrote:
> 2007/11/19, Alex V. Myltsev <avm / altlinux.org>:
> > Update of /people/avm/packages/rpm.git
> [...]
> > --- a/build/reqprov.c
> > +++ b/build/reqprov.c
> [...]
> > +#define PRIVATE_PREFIX "[private]"
> > +
> > +/* If there is a PRIVATE_PREFIX at the beginning of depName, skip it. */
> > +__attribute__((visibility ("hidden")))
> > +const char* rpmStripDepPrefix(const char* depName)
> > +{
> > + if (!strncmp(depName, PRIVATE_PREFIX, strlen(PRIVATE_PREFIX))) {
> > + depName += strlen(PRIVATE_PREFIX);
> > + }
> > + return depName;
> > +}
> > +
> [...]
>
> Почему бы не заменить strlen(PRIVATE_PREFIX) на sizeof(PRIVATE_PREFIX)-1 ?
>
> Читабельность кода чуток уменьшится, зато длинна строки оба раза будет
> вычисляться при компиляции, а не в run-time.
Кажется gcc умеет оптимизировать strlen для константных строк.
> Это я так, лишь предлагаю.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-20 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 11:12 ` Slava Semushin
2007-11-20 11:18 ` Alexey Tourbin [this message]
2007-11-20 12:08 ` Денис Смирнов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120111801.GI23589@solemn.turbinal \
--to=at@altlinux.ru \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git