From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 11 Aug 2007 02:35:14 +0400 From: Alexey Tourbin To: ALT Devel discussion list Message-ID: <20070810223514.GA7530@solemn.turbinal> Mail-Followup-To: ALT Devel discussion list References: <20070810162933.D1EC08E80D5@ssh.git.local.altlinux.org> <20070810221738.GA9864@nomad.office.altlinux.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5cXpu7evJfjLw2dJ" Content-Disposition: inline In-Reply-To: <20070810221738.GA9864@nomad.office.altlinux.org> Subject: Re: [devel] [git update] packages/hasher: heads/master X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.9rc1 Precedence: list Reply-To: ALT Devel discussion list List-Id: ALT Devel discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2007 22:35:13 -0000 Archived-At: List-Archive: List-Post: --5cXpu7evJfjLw2dJ Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 11, 2007 at 02:17:38AM +0400, Dmitry V. Levin wrote: > On Fri, Aug 10, 2007 at 08:29:33PM +0400, Alexey M. Tourbin wrote: > > Update of /people/at/packages/hasher.git > [...] > > On the "install ... && Verbose ... || Fatal ..." clauses. I think = this > > is overkill. >=20 > =ED=CE=C5 =D7=C1=D6=CE=CF =CE=C5 =D4=CF=CC=D8=CB=CF =D7=C9=C4=C5=D4=D8 = =D0=D2=C9=DE=C9=CE=D5 =D3=C2=CF=D1, =CE=CF =C9 =D2=C5=C1=CB=C3=C9=C0 =D0=D2= =CF=C7=D2=C1=CD=CD=D9 =CE=C1 =D3=C2=CF=CA. > =F7=CF=DA=CD=CF=D6=CE=CF, =C4=C9=C1=C7=CE=CF=D3=D4=C9=CB=C1 =CF=D4 instal= l =C9 =C4=CF=D3=D4=C1=D4=CF=DE=CE=C1. =F2=C5=DB=C5=CE=C9=C5 =D0=D2=C9=CE= =C9=CD=C1=C5=D4=D3=D1 > =D3=D5=C2=DF=C5=CB=D4=C9=D7=CE=CF =D7 =CB=C1=D6=C4=CF=CD =CB=CF=CE=CB=D2= =C5=D4=CE=CF=CD =D3=CC=D5=DE=C1=C5. =F1 =D4=C1=CD =C4=C1=CC=D8=DB=C5 =CE=C1=D0=C9=D3=C1=CC, =DE=D4=CF =CE=C5=CC= =D8=DA=D1 =D7=CF=CF=C2=DD=C5 =D7=D3=A3 =D0=D2=CF=D7=C5=D2=C9=D4=D8, =C9 =D0= =D2=C9=C8=CF=C4=C9=D4=D3=D1 =D0=CF=CC=C1=C7=C1=D4=D8=D3=D1 =CE=C1 =CE=C5=CB=CF=D4=CF=D2=D9=C5 =D7=C5=DD= =C9. =EE=C1=D0=D2=C9=CD=C5=D2, =CB=CF=C7=C4=C1 =D4=D9 =D0=C9=DB=C5=DB=D8 if grep ^... file; then ... =D4=D9 =CE=C5 =CF=D6=C9=C4=C1=C5=DB=D8, =DE=D4=CF grep =D5=D0=C1=C4=A3=D4 = =D7 SEGV, =CF=C4=CE=C1=CB=CF =D6=C5 #9941 (fixed). =E2=CF=CC=C5=C5 =D3=D4=D2=CF=C7=CF, =CE=C1=D7=C5=D2=CE=CF=C5, =CE=C1=C4=CF = =D0=C9=D3=C1=D4=D8 if grep ^... file; rc=3D$?; [ $rc -eq 0 ]; then match elif [ $rc -eq 1 ]; then no match else internal error fi =E1 =D4=C1=CB=D6=C5 =C5=D3=CC=C9 =D3=D4=D2=CF=C7=CF =D0=D2=CF=D7=C5=D2=D1= =D4=D8 =D3=D4=C1=D4=D5=D3, =D4=CF =CE=C5=CC=D8=DA=D1 =D0=CF=CC=D8=DA=CF=D7= =C1=D4=D8=D3=D1 =D0=C1=CA=D0=C1=CD=C9. =F7 =CF=C2=DD=C5=CD, =CE=D5=D6=CE=CF =CB=C1=CB=C9=CD-=D4=CF =CF=C2=D2=C1=DA= =CF=CD =D0=D2=C5=C4=D7=C9=C4=C5=D4=D8 =D0=D2=C9=DE=C9=CE=D5 =D3=C2=CF=D1, = =D4=CF=C7=C4=C1 =D3=D4=CF=C9=D4 =D0=D2=CF=D7=C5=D2=D1=D4=D8 =C9 =D0=C9=D3=C1=D4=D8 =C2=CF=CC=C5=C5 =DE=C5= =CC=CF=D7=C5=DE=C5=D3=CB=D5=C0 =C4=C9=C1=C7=CE=CF=D3=D4=C9=CB=D5. =E9=CE= =C1=DE=C5 =D2=C5=D6=C9=CD "sh -e" =C4=C1=A3=D4 =CB=C1=CB =C2=D9 =CF=D0=D4=C9=CD=C1=CC=D8=CE=D9=CA =D7=C1=D2= =C9=C1=CE=D4 -- =CE=C5 =CE=C1=C4=CF =C4=CF=D0=C9=D3=D9=D7=C1=D4=D8 =CB =CB= =C1=D6=C4=CF=CA =CB=CF=CD=C1=CE=C4=C5 "|| Fatal ...". > > On the "if shell_function ...; then ...' clauses. This is evil. D= on't use > > shell function in the "if" conditions, because "sh -e" mode is disa= bled for > > such calls. You can no longer expect that something "just fails". >=20 > =F4=CF =D6=C5 =D3=C1=CD=CF=C5 =CB=C1=D3=C1=C5=D4=D3=D1 =C9 shell_function= && on_success || on_failure. =FC=D4=CF =CF=DE=C5=CE=D8 =CE=C5=D0=D2=C9=D1=D4=CE=CF. :( > > + rm -rf cache/contents/list.new > > + mkdir -p $verbose cache/contents/list.new >=20 > =FA=C4=C5=D3=D8 =C9 =C4=C1=CC=C5=C5, "rm -rf" =D3 =D0=CF=D3=CC=C5=C4=D5= =C0=DD=C9=CD "mkdir -p" =CE=C1 =CF=C4=C9=CE =C9 =D4=CF=D4 =D6=C5 =CB=C1=D4= =C1=CC=CF=C7 -- > =DC=D4=CF =CE=C5=CB=CF=CE=D3=C9=D3=D4=C5=CE=D4=CE=CF; "-p" =D3=C2=C9=D7= =C1=C5=D4 =D3 =D4=CF=CC=CB=D5 =DE=C9=D4=C1=C0=DD=C5=C7=CF =CB=CF=C4. =E4=C1, =CE=C1=C4=CF =C2=D9=CC=CF =C2=C5=DA -p =C4=C5=CC=C1=D4=D8. > > + rm -rf cache/contents/tmp > > + mkdir -p cache/contents/tmp > > + local contents=3Dcache/contents/tmp/contents > [...] > > + contents_index_bin=3Dchroot/.host/contents_index_bin > [...] > > + cat <"$contents.bin" >"$contents_index_bin" > > + rm -rf cache/contents/tmp >=20 > =FA=C4=C5=D3=D8 =CD=CF=D6=CE=CF =DA=C1=CD=C5=CE=C9=D4=D8 cat =CE=C1 mv. =E4=C1. > [...] > > + rm -rf cache/contents/{index,list} > > + install -p -m644 $verbose chroot/.host/contents_index_bin cache/conte= nts/contents_index_bin > > + install -p -m644 $verbose chroot/.host/contents_index_all.gz cache/co= ntents/contents_index_all.gz >=20 > =F4=CF=C7=C4=C1 =D5=D6 ln. =F1 =D3=C8=CF=C4=D5 =CE=C5 =D3=CF=CF=C2=D2=C1=DA=C9=CC, =CB=C1=CB=C9=C5 =D4= =C1=CD =D0=D2=C1=D7=C1 =D0=CF=CC=D5=DE=C1=C0=D4=D3=D1. =EB=C1=CB =D1 =D0= =CF=CE=C9=CD=C1=C0, =C9=DA=CE=D5=D4=D2=C9 =DE=D2=D5=D4=C1 =C6=C1=CA=CC =CD=CF=C4=C9=C6=C9=C3=C9= =D2=CF=D7=C1=D4=D8 =CE=C5=CC=D8=DA=D1, =C1 =D7=CF=D4 =D3=CE=C1=D2=D5=D6=C9 = =DE=D2=D5=D4=C1 =CD=CF=C4=C9=C6=C9=C3=C9=D2=CF=D7=C1=D4=D8 =CD=CF=D6=CE=CF, =C9 =CF=CE =C9= =DA=CD=C5=CE=C9=D4=D3=D1 =D7 =DE=D2=D5=D4=C5. --5cXpu7evJfjLw2dJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGvOgifBKgtDjnu0YRAvHsAKC4SlKUCwiqsJ/dCpc6iTaUlXRJYgCg5Sfd NcG4QTEdI+LhEa1sPJAptf0= =m3j7 -----END PGP SIGNATURE----- --5cXpu7evJfjLw2dJ--