Re: [devel] [git update] packages/hasher: heads/arm-port

Re: [devel] [git update] packages/hasher: heads/arm-port

[Dmitry V. Levin]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

On Wed, Jun 20, 2007 at 04:26:45PM +0400, Kirill A. Shutemov wrote:
> Update of /people/kas/packages/hasher.git
> 
> Changes statistics since common ancestor `1.1.1-alt1-22-gf75ca3b' follows:
>  hasher/hsh                 |    8 +++++++-
>  hasher/hsh-fakedev         |    2 +-
>  hasher/hsh-mkchroot        |    8 +++++++-
>  hasher/hsh-sh-functions.in |   10 +++++++---
>  hasher/mkaptbox            |    2 +-
>  5 files changed, 23 insertions(+), 7 deletions(-)
> 
> Changelog since common ancestor `1.1.1-alt1-22-gf75ca3b' follows:
> commit ca290a3c2ff65ea579acef2fac019ecec38760a1
> Author: Kirill A. Shutemov <k.shutemov@gmail>
> Date:   Wed Jun 20 14:02:05 2007 +0259
> 
>     - hsh: --with-qemu option
>     - hsh-mkchroot: --with-qemu option: copy qemu to .host directory
>     - hsh-sh-functions.in:
>       + $qemu_arch global variable added
>       + pass --ignorearch to rpm in update_RPM_database

Add qemu support

hsh: Add --with-qemu= option.

hsh-mkchroot: Add --with-qemu= option to install qemu executable for
specified architecture into the chroot .host directory.

hsh-sh-functions.in: Define qemu_arch global variable.

hsh-sh-functions.in (update_RPM_database): Pass --ignorearch to rpmi
invocation.

[...]
> +  --with-qemu=ARCH                  copy qemu to .host dir;

copy qemu executable into the chroot .host directory;

> +[ -n "$qemu_arch" ] && install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" .host/

[ -z "$qemu_arch" ] ||
	install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" ".host/qemu-$qemu_arch"

Кстати говоря, явное упоминание "/usr/bin/" мне тоже не нравится.
Хорошо бы внедрить absolute() из /etc/init.d/functions.

Остальное нормально.


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [devel] [git update] packages/hasher: heads/arm-port

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On [Wed, 20.06.2007 17:19], Dmitry V. Levin wrote:
> On Wed, Jun 20, 2007 at 04:26:45PM +0400, Kirill A. Shutemov wrote:
> > +[ -n "$qemu_arch" ] && install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" .host/
> 
> [ -z "$qemu_arch" ] ||
> 	install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" ".host/qemu-$qemu_arch"
> 
Чем '[ -z "$qemu_arch" ] ||' предпочтительней '[ -n "$qemu_arch" ] &&' ?

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys LLC, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [devel] [git update] packages/hasher: heads/arm-port

[Dmitry V. Levin]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

On Wed, Jun 20, 2007 at 08:04:22PM +0300, Kirill A. Shutemov wrote:
> On [Wed, 20.06.2007 17:19], Dmitry V. Levin wrote:
> > On Wed, Jun 20, 2007 at 04:26:45PM +0400, Kirill A. Shutemov wrote:
> > > +[ -n "$qemu_arch" ] && install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" .host/
> > 
> > [ -z "$qemu_arch" ] ||
> > 	install -p -m755 $verbose "/usr/bin/qemu-$qemu_arch.static" ".host/qemu-$qemu_arch"
> > 
> Чем '[ -z "$qemu_arch" ] ||' предпочтительней '[ -n "$qemu_arch" ] &&' ?

Я стараюсь избегать ненулевого $? в режиме -e.


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [devel] [git update] packages/hasher: heads/arm-port

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

On [Wed, 20.06.2007 17:19], Dmitry V. Levin wrote:
> Кстати говоря, явное упоминание "/usr/bin/" мне тоже не нравится.
> Хорошо бы внедрить absolute() из /etc/init.d/functions.

Сделал . /etc/init.d/functions в hsh-mkchroot - сломалась сборка. Не понял
почему.

> Остальное нормально.
Остальное поправил.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys LLC, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [devel] [git update] packages/hasher: heads/arm-port

[Dmitry V. Levin]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

On Wed, Jun 20, 2007 at 09:08:12PM +0300, Kirill A. Shutemov wrote:
> On [Wed, 20.06.2007 17:19], Dmitry V. Levin wrote:
> > Кстати говоря, явное упоминание "/usr/bin/" мне тоже не нравится.
> > Хорошо бы внедрить absolute() из /etc/init.d/functions.
> 
> Сделал . /etc/init.d/functions в hsh-mkchroot - сломалась сборка. Не понял
> почему.

/etc/init.d/functions для этого не предназначен.
OK, я сам сделаю.


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]