Re: [devel] perl-Image-MetaData-JPEG-0.15-alt1: i586 rebuild failed [3]

Re: [devel] perl-Image-MetaData-JPEG-0.15-alt1: i586 rebuild failed [3]

[Victor Forsyuk]

On Wed, Apr 11, 2007 at 06:27:42PM +0400, QA Team Robot <qa@altlinux.org> wrote:
> Package: perl-Image-MetaData-JPEG-0.15-alt1
> Packager: Victor Forsyuk <force@altlinux>
> Status: i586 rebuild failed.
> Cannot build this package for 3 week(s) (since Mon Mar 19 2007).
> Please investigate.
> 
> Why:
> 
> #     undef
> Can't call method "get_app13_data" on an undefined value at t/JPEG_4_app13_set.t line 144.
> # Looks like you planned 53 tests but only ran 18.
> # Looks like you failed 1 test of 18 run.
> # Looks like your test died just after 18.
> dubious
> 	Test returned status 255 (wstat 65280, 0xff00)
> DIED. FAILED tests 18-53
> 	Failed 36/53 tests, 32.08% okay
> t/JPEG_5_exif..............# Testing APP1 Exif data routines
> ok
> t/JPEG_5_exif_GPS..........# Testing APP1 Exif data routines (GPS_DATA)
> Modification of a read-only value attempted at /usr/src/RPM/BUILD/Image-MetaData-JPEG-0.15/blib/lib/Image/MetaData/JPEG.pm line 134.

Что делать-то будем... Perl откатывать или как?

Ideas?

Re: [devel] perl-Image-MetaData-JPEG-0.15-alt1: i586 rebuild failed [3]

[Alexey Tourbin]

[-- Attachment #1: Type: text/plain, Size: 5093 bytes --]

On Wed, Apr 11, 2007 at 06:03:35PM +0300, Victor Forsyuk wrote:
> > #     undef
> > Can't call method "get_app13_data" on an undefined value at t/JPEG_4_app13_set.t line 144.
> > # Looks like you planned 53 tests but only ran 18.
> > # Looks like you failed 1 test of 18 run.
> > # Looks like your test died just after 18.
> > dubious
> > 	Test returned status 255 (wstat 65280, 0xff00)
> > DIED. FAILED tests 18-53
> > 	Failed 36/53 tests, 32.08% okay
> > t/JPEG_5_exif..............# Testing APP1 Exif data routines
> > ok
> > t/JPEG_5_exif_GPS..........# Testing APP1 Exif data routines (GPS_DATA)
> > Modification of a read-only value attempted at /usr/src/RPM/BUILD/Image-MetaData-JPEG-0.15/blib/lib/Image/MetaData/JPEG.pm line 134.
> 
> Что делать-то будем... Perl откатывать или как?
> Ideas?

Перл нельзя откатывать, только накатывать, по нарастающей.
Нельзя теперича стало в константную строку писать через PerlIO::scalar.
В апстриме мне какой-то перец сказал что типа так и надо.
http://www.nntp.perl.org/group/perl.perl5.porters/2007/04/msg122790.html

Придется исправить test suite.

--- Image-MetaData-JPEG-0.15/t/JPEG_3_comments.t-	2004-11-01 19:54:13 +0300
+++ Image-MetaData-JPEG-0.15/t/JPEG_3_comments.t	2007-04-11 20:43:48 +0400
@@ -119,7 +119,7 @@ isnt( $@, '', "Invalid index in join_com
 #########################
 $image->remove_all_comments();
 $image->add_comment($_) for @savelist; $num = @savelist;
-$bufferref = \ "dummy";
+$bufferref = \my $buf;
 $image->save($bufferref);
 $newim = $cname->new($bufferref);
 @list = $newim->get_comments();
--- Image-MetaData-JPEG-0.15/t/JPEG_4_app13_set.t-	2005-10-26 04:13:32 +0400
+++ Image-MetaData-JPEG-0.15/t/JPEG_4_app13_set.t	2007-04-11 20:44:33 +0400
@@ -135,7 +135,7 @@ $seg1->set_app13_data($ht, 'REPLACE', 'I
 $hashtot = $seg1->get_app13_data('NUMERIC', 'IPTC');
 $seg1->set_app13_data($hn, 'ADD', 'IPTC');
 push @{$$hashtot{$_}}, @{$$hn{$_}} for keys %$hn;
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image = $cname->new($ref, 'APP13', 'FASTREADONLY');
 isnt( $image, undef, "File written and re-read");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_GPS.t-	2005-10-25 21:56:06 +0400
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_GPS.t	2007-04-11 20:45:49 +0400
@@ -95,7 +95,7 @@ $hash = $image->set_Exif_data($GPS_data,
 is_deeply( $hash, {}, "adding without the GPS dir" );
 
 #########################
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image2 = $cname->new($ref, '^APP1$');
 is_deeply( $image2->{segments}, $image->{segments}, "Write and reread works");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_IFD.t-	2005-10-25 22:02:18 +0400
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_IFD.t	2007-04-11 20:46:30 +0400
@@ -180,7 +180,7 @@ $hash = $image->set_Exif_data($IFD_data,
 is_deeply( $hash, {}, "adding without the IFD1 dir" );
 
 #########################
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image2 = $cname->new($ref, '^APP1$');
 is_deeply( $image2->{segments}, $image->{segments}, "Write and reread works");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_IMAGE.t-	2006-01-07 00:36:33 +0300
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_IMAGE.t	2007-04-11 20:47:14 +0400
@@ -183,7 +183,7 @@ $hash = $image->set_Exif_data($IMAGE_dat
 is_deeply( $hash, {}, "adding without the Exif segment" );
 
 #########################
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image2 = $cname->new($ref, '^APP1$');
 is_deeply( $image2->{segments}, $image->{segments}, "Write and reread works");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_Interop.t-	2005-03-07 20:10:42 +0300
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_Interop.t	2007-04-11 20:48:51 +0400
@@ -84,7 +84,7 @@ $hash = $image->set_Exif_data($data2, 'I
 is_deeply( $hash, {}, "adding without the Interop. dir" );
 
 #########################
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image2 = $cname->new($ref, '^(APP1|SOS)$');
 is_deeply( $image2->{segments}, $image->{segments}, "Write and reread works");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_SubIFD.t-	2005-10-25 22:06:41 +0400
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_SubIFD.t	2007-04-11 20:49:20 +0400
@@ -119,7 +119,7 @@ $hash = $image->set_Exif_data($SubIFD_da
 is_deeply( $hash, {}, "adding without the SubIFD dir" );
 
 #########################
-$ref = \ "dummy";
+$ref = \my $buf;
 $image->save($ref);
 $image2 = $cname->new($ref, '^APP1$');
 is_deeply( $image2->{segments}, $image->{segments}, "Write and reread works");
--- Image-MetaData-JPEG-0.15/t/JPEG_5_exif_Thumbnail.t-	2005-12-18 19:38:52 +0300
+++ Image-MetaData-JPEG-0.15/t/JPEG_5_exif_Thumbnail.t	2007-04-11 20:50:15 +0400
@@ -48,7 +48,7 @@ $result = $image->set_Exif_data($dataref
 is_deeply( $result, {}, "New JPEG thumbnail set (scalar)" );
 
 #########################
-$dataref2 = \ 'dummy';
+$dataref2 = \my $buf;
 $image->save($dataref2);
 $image = $cname->new($dataref2, '^APP1$');
 $dataref2 = $image->get_Exif_data('THUMBNAIL');


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [devel] perl-Image-MetaData-JPEG-0.15-alt1: i586 rebuild failed [3]

[Victor Forsyuk]

On Wed, Apr 11, 2007 at 08:53:05PM +0400, Alexey Tourbin <at@altlinux.ru> wrote:
> > > ok
> > > t/JPEG_5_exif_GPS..........# Testing APP1 Exif data routines (GPS_DATA)
> > > Modification of a read-only value attempted at /usr/src/RPM/BUILD/Image-MetaData-JPEG-0.15/blib/lib/Image/MetaData/JPEG.pm line 134.
> > 
> > Что делать-то будем... Perl откатывать или как?
> > Ideas?
> 
> Перл нельзя откатывать, только накатывать, по нарастающей.
> Нельзя теперича стало в константную строку писать через PerlIO::scalar.
> В апстриме мне какой-то перец сказал что типа так и надо.
> http://www.nntp.perl.org/group/perl.perl5.porters/2007/04/msg122790.html
> 
> Придется исправить test suite.

Спасибо за патч! Исправил.